[ammarfaizi2-block:google/android/kernel/common/android11-kiwi-5.4 2649/9999] drivers/usb/gadget/function/f_accessory.c:295:23: sparse: sparse: Using plain integer as NULL pointer

[ammarfaizi2-block:google/android/kernel/common/android11-kiwi-5.4 2649/9999] drivers/usb/gadget/function/f_accessory.c:295:23: sparse: sparse: Using plain integer as NULL pointer

[kernel test robot]

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android11-kiwi-5.4
head:   59031e281b1833e9bf16df27a80d4854ed33aef3
commit: e0ea2cf7660ddd619bfecf3cd81127a5ae27b971 [2649/9999] ANDROID: usb: f_accessory: Avoid bitfields for shared variables
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220717/202207170427.MhlD7SKH-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/ammarfaizi2/linux-block/commit/e0ea2cf7660ddd619bfecf3cd81127a5ae27b971
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android11-kiwi-5.4
        git checkout e0ea2cf7660ddd619bfecf3cd81127a5ae27b971
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/usb/gadget/function/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/usb/gadget/function/f_accessory.c:295:23: sparse: sparse: Using plain integer as NULL pointer
   drivers/usb/gadget/function/f_accessory.c:702:35: sparse: sparse: Using plain integer as NULL pointer
   drivers/usb/gadget/function/f_accessory.c:722:23: sparse: sparse: Using plain integer as NULL pointer
   drivers/usb/gadget/function/f_accessory.c:758:23: sparse: sparse: Using plain integer as NULL pointer
>> drivers/usb/gadget/function/f_accessory.c:1408:5: sparse: sparse: symbol 'acc_ctrlrequest_configfs' was not declared. Should it be static?

vim +295 drivers/usb/gadget/function/f_accessory.c

483cb5629ea7893 Benoit Goby 2011-12-19  286  
483cb5629ea7893 Benoit Goby 2011-12-19  287  /* remove a request from the head of a list */
483cb5629ea7893 Benoit Goby 2011-12-19  288  static struct usb_request *req_get(struct acc_dev *dev, struct list_head *head)
483cb5629ea7893 Benoit Goby 2011-12-19  289  {
483cb5629ea7893 Benoit Goby 2011-12-19  290  	unsigned long flags;
483cb5629ea7893 Benoit Goby 2011-12-19  291  	struct usb_request *req;
483cb5629ea7893 Benoit Goby 2011-12-19  292  
483cb5629ea7893 Benoit Goby 2011-12-19  293  	spin_lock_irqsave(&dev->lock, flags);
483cb5629ea7893 Benoit Goby 2011-12-19  294  	if (list_empty(head)) {
483cb5629ea7893 Benoit Goby 2011-12-19 @295  		req = 0;
483cb5629ea7893 Benoit Goby 2011-12-19  296  	} else {
483cb5629ea7893 Benoit Goby 2011-12-19  297  		req = list_first_entry(head, struct usb_request, list);
483cb5629ea7893 Benoit Goby 2011-12-19  298  		list_del(&req->list);
483cb5629ea7893 Benoit Goby 2011-12-19  299  	}
483cb5629ea7893 Benoit Goby 2011-12-19  300  	spin_unlock_irqrestore(&dev->lock, flags);
483cb5629ea7893 Benoit Goby 2011-12-19  301  	return req;
483cb5629ea7893 Benoit Goby 2011-12-19  302  }
483cb5629ea7893 Benoit Goby 2011-12-19  303  

:::::: The code at line 295 was first introduced by commit
:::::: 483cb5629ea7893f94481511e630ae14a5c0d1c0 ANDROID: usb: gadget: f_accessory: Add Android Accessory function

:::::: TO: Benoit Goby <benoit@android.com>
:::::: CC: Todd Kjos <tkjos@google.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp