public inbox for [email protected]
 help / color / mirror / Atom feed
From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Muhammad Rizki <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: [PATCH v2 06/18] daemon: Use traceback.format_exc() to get the error detail
Date: Tue, 19 Jul 2022 07:17:32 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

From: Muhammad Rizki <[email protected]>

`print(f"[__run]: Error: {e}")` doesn't give enough information for
debugging because it doesn't show the traceback, files, line numbers,
etc. It only shows the error message raised by an exception. This is
severely lacking and very bad for debugging experience.

Use `traceback.format_exc()` instead to get a better log because it
shows a complete traceback of the error.

Signed-off-by: Muhammad Rizki <[email protected]>
---
 daemon/scraper/bot.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/daemon/scraper/bot.py b/daemon/scraper/bot.py
index 04caab6..2392b61 100644
--- a/daemon/scraper/bot.py
+++ b/daemon/scraper/bot.py
@@ -17,6 +17,7 @@ import pyrogram
 import asyncio
 import shutil
 import re
+import traceback
 
 
 class BotMutexes():
@@ -63,8 +64,8 @@ class Bot():
 		for url in self.ATOM_URLS:
 			try:
 				await self.__handle_atom_url(url)
-			except Exception as e:
-				print(f"[__run]: Error: {e}")
+			except:
+				print(traceback.format_exc())
 
 		if not self.isRunnerFixed:
 			self.isRunnerFixed = True
-- 
Muhammad Rizki


  parent reply	other threads:[~2022-07-19  0:18 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19  0:17 [PATCH v2 00/18] Plan to redesign codes Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 01/18] Fix __send_patch_msg function parameter Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 02/18] Fix import problem Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 03/18] Add default temporary directory Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 04/18] Move the Telegram bot session into the storage directory Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 05/18] daemon: Fix raw lore URL on the inline keyboard button Muhammad Rizki
2022-07-19  0:17 ` Muhammad Rizki [this message]
2022-07-19  0:17 ` [PATCH v2 07/18] Re-design send email message to Telegram Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 08/18] Move ____send_patch_msg Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 09/18] Move prepare for patch and clean up patch functions Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 10/18] Create fix_utf8_chars function Muhammad Rizki
2022-07-19  8:20   ` Ammar Faizi
2022-07-19  0:17 ` [PATCH v2 11/18] Recode some codes Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 12/18] Fix indentation issue Muhammad Rizki
2022-07-19  8:15   ` Ammar Faizi
2022-07-19  0:17 ` [PATCH v2 13/18] Remove whitespace Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 14/18] Remove prepare patch and clean up patch Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 15/18] daemon: Remove unused imports Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 16/18] daemon: Add @handle_flood decorator and remove some functions Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 17/18] daemon: Remove __send_patch_msg() Muhammad Rizki
2022-07-19  0:17 ` [PATCH v2 18/18] daemon: Remove unused imports Muhammad Rizki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox