From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from integral2.. (unknown [125.160.110.15]) by gnuweeb.org (Postfix) with ESMTPSA id 1DD627E24B; Mon, 1 Aug 2022 12:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1659355213; bh=1CxphM8mT7LexVSNdtj4rN64OESklygPtbgpgoZ2cjI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UdkuVedwwkU8KBKc1UvD6yl1x1Rxj154rCtYlaHEC1eX/hh/5iJNNTYDgtyfztW9K P5PFyJtVvClMepGqYyPY/Xcq6PxEzEXEiykCKzd1L4MFd16+DOcIhjrYWRb0YFdf9R oj2dkSc/BrXDbIKaUJDKEaRDTZg4i+7HTNYrv5a0eB+19LzDLWdm+I3vXRAtdX2Kjy ZbuUPB7+FvgNxTAuzjGGPFPNFr+v7Ut/r4otyT50HOGADXsq1DOheiVsY/mAekIuxF lCKxx8BtFwb3RTPdHbuwGUoGzjf1TnnME3qsw0SrSwSi7tJOBoyKfHFerw9tSocyv9 NelvvgqFFfZZg== From: Ammar Faizi To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Ammar Faizi , kernel test robot , Dan Carpenter , Moshe Shemesh , Jiri Pirko , Fernanda Ma'rouf , netdev Mailing List , GNU/Weeb Mailing List , Linux Kernel Mailing List , kbuild Mailing List , kbuild-all Mailing List Subject: [PATCH] net: devlink: Fix missing mutex_unlock() call Date: Mon, 1 Aug 2022 18:59:56 +0700 Message-Id: <20220801115742.1309329-1-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <202207311503.QBFSGqiL-lkp@intel.com> References: <202207311503.QBFSGqiL-lkp@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi Commit 2dec18ad826f forgets to call mutex_unlock() before the function returns in the error path: New smatch warnings: net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \ returns '®ion->snapshot_lock'. Make sure we call mutex_unlock() in this error path. Reported-by: kernel test robot Reported-by: Dan Carpenter Fixes: 2dec18ad826f52658f7781ee995d236cc449b678 ("net: devlink: remove region snapshots list dependency on devlink->lock") Signed-off-by: Ammar Faizi --- net/core/devlink.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 889e7e3d3e8a..5da5c7cca98a 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -6315,8 +6315,10 @@ devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) snapshot = devlink_region_snapshot_get_by_id(region, snapshot_id); - if (WARN_ON(!snapshot)) - return -EINVAL; + if (WARN_ON(!snapshot)) { + err = -EINVAL; + goto unlock; + } msg = devlink_nl_region_notify_build(region, snapshot, DEVLINK_CMD_REGION_NEW, base-commit: 0a324c3263f1e456f54dd8dc8ce58575aea776bc -- Ammar Faizi