From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gnuweeb.org (Postfix) with ESMTPS id B661680615 for ; Sat, 20 Aug 2022 12:41:15 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=EZPG2XYO; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660999275; x=1692535275; h=date:from:to:cc:subject:message-id:mime-version; bh=r0CjyZIwoXGm37gWEYMXqTzbi7InVQsa8cQxk6P39j0=; b=EZPG2XYO9R3Sy7BZsW7MhhzqMK4fCboDk3uaClSm8RlfoYIEL70A86fb AYR/Rz+1WBhYJE8QQvDcy0nNs+5u/OatVsALUJuDTMjoup6Yj2LWjBQ/O ZgMh4UjHQRHt0zB/KOfveesmX8uj2nPGOul5b/uccYQ9oFxeESNkRd8VV VSEh/WNHTqLZQ/UITsPwB5JrjeLCn3m/4b6L1LRjkjdB9a3eD0OxPwzeQ ZYgVdRDNqCbU8hlgjNoyEDoCJa+WnX2I6DrZ3M8jgquTBqlEHxhfwGliX i9MrT3rdi62+P3g7/aAP6Oon7CVuOTFxQ6ZXHEsSwR7eLb4x2Htfcmluy g==; X-IronPort-AV: E=McAfee;i="6500,9779,10444"; a="379468046" X-IronPort-AV: E=Sophos;i="5.93,251,1654585200"; d="scan'208";a="379468046" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2022 05:41:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,251,1654585200"; d="scan'208";a="750798481" Received: from lkp-server01.sh.intel.com (HELO 44b6dac04a33) ([10.239.97.150]) by fmsmga001.fm.intel.com with ESMTP; 20 Aug 2022 05:41:06 -0700 Received: from kbuild by 44b6dac04a33 with local (Exim 4.96) (envelope-from ) id 1oPNmj-0002f4-2K; Sat, 20 Aug 2022 12:41:05 +0000 Date: Sat, 20 Aug 2022 20:40:30 +0800 From: kernel test robot To: Ammar Faizi , GNU/Weeb Mailing List Cc: kbuild-all@lists.01.org Subject: [ammarfaizi2-block:google/android/kernel/common/android12-kiwi-5.10 8804/9999] drivers/virtio/virtio_pvclock.c:49:6: warning: no previous prototype for function 'update_suspend_time' Message-ID: <202208202050.VZBnUOPU-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: Hi Colin, FYI, the error/warning still remains. tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-kiwi-5.10 head: edf4da79d443f97049926ace891b5d6d235f7539 commit: 029865ac9555743665dd106b4bbefb2f371849e9 [8804/9999] ANDROID: virtio: virtio_pvclock: initial driver impl config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220820/202208202050.VZBnUOPU-lkp@intel.com/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c9a41fe60ab62f7a40049c100adcc8087a47669b) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/ammarfaizi2/linux-block/commit/029865ac9555743665dd106b4bbefb2f371849e9 git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-kiwi-5.10 git checkout 029865ac9555743665dd106b4bbefb2f371849e9 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/virtio/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/virtio/virtio_pvclock.c:49:6: warning: no previous prototype for function 'update_suspend_time' [-Wmissing-prototypes] void update_suspend_time(struct work_struct *work) ^ drivers/virtio/virtio_pvclock.c:49:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void update_suspend_time(struct work_struct *work) ^ static >> drivers/virtio/virtio_pvclock.c:295:11: warning: mixing declarations and code is a C99 extension [-Wdeclaration-after-statement] uint32_t rating = ^ 2 warnings generated. vim +/update_suspend_time +49 drivers/virtio/virtio_pvclock.c 48 > 49 void update_suspend_time(struct work_struct *work) 50 { 51 u64 suspend_ns, suspend_time_delta = 0; 52 struct timespec64 inject_time; 53 struct virtio_pvclock *vp; 54 55 vp = container_of(work, struct virtio_pvclock, 56 update_suspend_time_work); 57 58 virtio_cread(vp->vdev, struct virtio_pvclock_config, suspend_time_ns, 59 &suspend_ns); 60 61 mutex_lock(&vp->inject_suspend_lock); 62 if (suspend_ns > vp->injected_suspend_ns) { 63 suspend_time_delta = suspend_ns - vp->injected_suspend_ns; 64 vp->injected_suspend_ns = suspend_ns; 65 } 66 mutex_unlock(&vp->inject_suspend_lock); 67 68 if (suspend_time_delta == 0) { 69 dev_err(&vp->vdev->dev, 70 "%s: suspend_time_ns is less than injected_suspend_ns\n", 71 __func__); 72 return; 73 } 74 75 inject_time = ns_to_timespec64(suspend_time_delta); 76 77 timekeeping_inject_sleeptime64(&inject_time); 78 79 dev_info(&vp->vdev->dev, "injected sleeptime: %llu ns\n", 80 suspend_time_delta); 81 } 82 -- 0-DAY CI Kernel Test Service https://01.org/lkp