public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Alviro Iskandar Setiawan <[email protected]>
Cc: Ammar Faizi <[email protected]>,
	Muhammad Rizki <[email protected]>,
	Kanna Scarlet <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>
Subject: [PATCH v1 13/22] chnet: node: Add set request header function in NodeJS
Date: Sun, 21 Aug 2022 18:24:44 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

This adds set request header functionality. Also, update the ring.js
example to perform an HTTP request that executes this new function.

Signed-off-by: Ammar Faizi <[email protected]>
---
 chnet/chnet_node.cc | 41 +++++++++++++++++++++++++++++++++++++++++
 tests/js/ring.js    | 12 ++++++++++++
 2 files changed, 53 insertions(+)

diff --git a/chnet/chnet_node.cc b/chnet/chnet_node.cc
index cfa919b..1269577 100644
--- a/chnet/chnet_node.cc
+++ b/chnet/chnet_node.cc
@@ -352,6 +352,46 @@ static void CHN_NetSetMethod(const Napi::CallbackInfo &info)
 	ch->ch_.SetMethod(method.c_str());
 }
 
+static void CHN_NetSetRequestHeader(const Napi::CallbackInfo &info)
+{
+	constexpr static const char err_msg[] =
+		"chnet.set_request_header must be at least given 2 string arguments";
+	constexpr static const char err_msg2[] =
+		"chnet.set_request_header can only receive 3 arguments with the third argument being a boolean";
+
+	Napi::Env env = info.Env();
+	bool overwrite = true;
+	NodeCHNet *ch;
+	int nr_arg;
+
+
+	nr_arg = info.Length();
+	if (unlikely(nr_arg < 2 || !info[0].IsString() ||
+		     !info[1].IsString())) {
+		throw_js_exception(env, err_msg);
+		return;
+	}
+
+	if (unlikely(nr_arg > 3)) {
+		throw_js_exception(env, err_msg2);
+		return;
+	}
+
+	if (nr_arg == 3) {
+		if (unlikely(!info[2].IsBoolean())) {
+			throw_js_exception(env, err_msg2);
+			return;
+		}
+		overwrite = info[2].As<Napi::Boolean>();
+	}
+
+	ch = (NodeCHNet *)info.Data();
+	const std::string &key = info[0].ToString().Utf8Value();
+	const std::string &val = info[1].ToString().Utf8Value();
+	ch->ch_.SetRequestHeader(key.c_str(), val.c_str(), overwrite);
+}
+
+
 static Napi::Value CHN_NetReadBuf(const Napi::CallbackInfo &info)
 {
 	Napi::Env env = info.Env();
@@ -422,6 +462,7 @@ static Napi::Object CHN_CreateNet(const Napi::CallbackInfo &info)
 
 	obj_add_func(env, obj, ch, CHN_NetSetURL, "set_url");
 	obj_add_func(env, obj, ch, CHN_NetSetMethod, "set_method");
+	obj_add_func(env, obj, ch, CHN_NetSetRequestHeader, "set_request_header");
 	obj_add_func(env, obj, ch, CHN_NetReadRet, "read_ret");
 	obj_add_func(env, obj, ch, CHN_NetReadBuf, "read_buf");
 	obj_add_func(env, obj, ch, CHN_NetGetError, "get_error");
diff --git a/tests/js/ring.js b/tests/js/ring.js
index 3a4d25d..4b081ae 100644
--- a/tests/js/ring.js
+++ b/tests/js/ring.js
@@ -140,11 +140,23 @@ function test_simple_http()
 	assert(h.ch.read_ret() === payload.length);
 }
 
+function test_simple_http_set_header()
+{
+	const ua = "This is just a test user agent!";
+	let h = new SimpleHttp("http://127.0.0.1:8000/index.php?action=user_agent", "GET");
+	h.ch.set_request_header("User-Agent", ua);
+	h.prep_read(1024);
+	h.run();
+	assert(h.get_buffer() === ua);
+	assert(h.ch.read_ret() === ua.length);
+}
+
 function main()
 {
 	test_nop();
 	test_chnet_ring_multiple();
 	test_simple_http();
+	test_simple_http_set_header();
 }
 
 main();
-- 
Ammar Faizi


  parent reply	other threads:[~2022-08-21 11:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21 11:24 [PATCH v1 00/22] ncns updates Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 01/22] chnet: Add initial request body support Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 02/22] chnet: node: Add set_user_data support on SQE Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 03/22] tests/js/ring: Update the unit test to utilize set_user_data Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 04/22] binding.gyp: Add `-ggdb3` flag for better debugging experience Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 05/22] binding.gyp: Add `-Wno-enum-constexpr-conversion` flag Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 06/22] chnet: node: Add set_method function to set HTTP method Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 07/22] chnet: node: Add get_error function to return the error string Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 08/22] chnet: node: Add set_payload function to set HTTP req body Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 09/22] tests/js/ring: Add simple HTTP POST request example in NodeJS Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 10/22] chnet: Split construct URL req creation into a new function Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 11/22] chnet: Add set request header support Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 12/22] chnet: node: Fix unused variable warning Ammar Faizi
2022-08-21 11:24 ` Ammar Faizi [this message]
2022-08-21 11:24 ` [PATCH v1 14/22] tests/js/ring: Add more set header function test Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 15/22] chnet: node: Don't use static counter for data ID Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 16/22] tests/js/ring: Add JavaScript class wrapper example Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 17/22] chnet: Initial chunked request body support Ammar Faizi
2022-08-21 22:13   ` Alviro Iskandar Setiawan
2022-08-22  3:08     ` Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 18/22] chnet: Rework the chunked request body interface Ammar Faizi
2022-08-21 22:20   ` Alviro Iskandar Setiawan
2022-08-21 11:24 ` [PATCH v1 19/22] chnet: ring: Refactor the ring completely Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 20/22] chnet: Use busy-waiting for signal waiter Ammar Faizi
2022-08-21 22:29   ` Alviro Iskandar Setiawan
2022-08-21 11:24 ` [PATCH v1 21/22] chnet: ring: Bump max_entry to 2G Ammar Faizi
2022-08-21 11:24 ` [PATCH v1 22/22] tests/cpp: Delete basic.cpp as it's no longer relevant Ammar Faizi
2022-08-21 22:21   ` Alviro Iskandar Setiawan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox