[PATCH ncns v1 2/2] chnet: Add thread index specifier for chromium thread

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

Currently, all threads created by the chromium thread pool have task
comm name "chromium_thread". This naming is not helpful when we're
debugging multiple chromium threads. Set the name to "chromium-%u"
where %u is the thread index in the pool. It creates a way to
identify each chromium thread uniquely.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 chnet/chnet.cc | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/chnet/chnet.cc b/chnet/chnet.cc
index ba3c076..32078cc 100644
--- a/chnet/chnet.cc
+++ b/chnet/chnet.cc
@@ -664,11 +664,20 @@ public:
 	uint32_t		ref_count_;
 	uint32_t		idx_;
 
-	ch_thpool(void);
+	ch_thpool(uint32_t i);
+
+private:
+	inline static std::string gen_thread_name(uint32_t i)
+	{
+		char name[sizeof("chromium-xxxxxxxx")];
+
+		snprintf(name, sizeof(name), "chromium-%u", i);
+		return std::string(name);
+	}
 };
 
-ch_thpool::ch_thpool(void):
-	thread_("chromium_thread"),
+ch_thpool::ch_thpool(uint32_t i):
+	thread_(gen_thread_name(i)),
 	ref_count_(0)
 {
 	CHECK((void *)this == (void *)&thread_);
@@ -698,7 +707,7 @@ static base::Thread *get_thread(void)
 
 	tmp = thp[0];
 	if (!tmp) {
-		ret = new struct ch_thpool;
+		ret = new struct ch_thpool(0);
 		ret->idx_ = 0;
 		thp[0] = ret;
 		goto out;
@@ -711,7 +720,7 @@ static base::Thread *get_thread(void)
 
 		tmp = thp[i];
 		if (!tmp) {
-			ret = new struct ch_thpool;
+			ret = new struct ch_thpool(i);
 			ret->idx_ = i;
 			thp[i] = ret;
 			goto out;
-- 
Ammar Faizi