From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by gnuweeb.org (Postfix) with ESMTPS id D6F0D804D1 for ; Mon, 7 Nov 2022 08:02:31 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=FV662BMm; dkim-atps=neutral Received: by mail-wr1-f51.google.com with SMTP id j15so14914778wrq.3 for ; Mon, 07 Nov 2022 00:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=yLFXXeJQalHOtiJfGLbWfBN0AQbnvJ6LnCPg8PG/XjA=; b=FV662BMmYxbFtvjiEkjRuqjJrtOFBIQHXKf8tcE59ZJOJg8Di/R4ISDqBUdUObKMOS ZQN8QVk+fjLFuyOCZhmlY7RNxukTSVALvtAptOgrkfCQ9XmdpYRhbk009ZcRpVvpJtnb SscANdJFv6k2X/G8YJYA8k+FUn1ejgrn+h456fFeqcZegNDrZtYd+XxFoXNMy3ivjYj7 MSP3wD6YWtLSc/rYaVoiX17b2YJGeCI7tySTLds7exnVoQUZGZuvL2Mqfxfk2mTIwPtg CsH2JMajsdYmyfKfa+ZDzQFNC/QJiR6g28lzx7jKexdLtw4vDxzm7/Pr5Nkyt/837/UU zcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yLFXXeJQalHOtiJfGLbWfBN0AQbnvJ6LnCPg8PG/XjA=; b=GVTpXSmB6Q86+JywhI45e9POcN1zx6OpwOVkaKCcuMeGSGx/DYFb9tUficHWc0YXGm 9jnRru3gD23g6t5esB133R+6ujh16x5qN5Ch5uwjLyRjoBKCQAfnzgbP4UntgsTP20wV uxjovzwh29MsRAVs8gbVPD2s+YvrHxIr/LxzGynYqFcwQsw3xfxCd2en9AKJzf52cKTa vDC8o/rzF7YaSTObCMUrsfA1DSL5beo0oTj4Vw9RhmdQKTHpIPtfFo/VtBvPxTcc8c98 Zgnb+ni8OWJJPZ7HPtrCH38+yf/p5I5/gWK4HFFQBDrCjjs2xY5CEKJ+q8b689inGtDi 95gQ== X-Gm-Message-State: ACrzQf2CL2AjfkU14lVoqWGO3N2EM3KgguO3M4r9eLXYQD3t17j3uU+d PSK/SuwLvQLii7kRBph4XZI= X-Google-Smtp-Source: AMsMyM6U3ZECmOV22fEfrSpQBDzHIGf7UaBBUmd/OEUsoBH10DKXcqKPH3S905pT/suHUmRH0vjoiw== X-Received: by 2002:a05:6000:1f16:b0:238:3fc8:1f11 with SMTP id bv22-20020a0560001f1600b002383fc81f11mr13790120wrb.9.1667808150079; Mon, 07 Nov 2022 00:02:30 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id q2-20020a7bce82000000b003cf7292c553sm7318317wmj.13.2022.11.07.00.02.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 00:02:29 -0800 (PST) Date: Mon, 7 Nov 2022 11:02:26 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, David Howells Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Ammar Faizi , GNU/Weeb Mailing List Subject: [ammarfaizi2-block:dhowells/linux-fs/rxrpc-ringless-5 29/79] net/rxrpc/io_thread.c:52 rxrpc_error_report() error: uninitialized symbol 'skb'. Message-ID: <202211071354.ANknPOk9-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline List-Id: tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/rxrpc-ringless-5 head: ae32660a904fd27bf548d6bb4a3fc340645da2ca commit: ea8a55f838fb351b99eb2558a82492dc41246871 [29/79] rxrpc: Move error processing into the local endpoint I/O thread config: openrisc-randconfig-m031-20221106 compiler: or1k-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter New smatch warnings: net/rxrpc/io_thread.c:52 rxrpc_error_report() error: uninitialized symbol 'skb'. Old smatch warnings: net/rxrpc/io_thread.c:210 rxrpc_input_packet() warn: passing freed memory 'skb' vim +/skb +52 net/rxrpc/io_thread.c ea8a55f838fb35 David Howells 2022-10-10 43 void rxrpc_error_report(struct sock *sk) ea8a55f838fb35 David Howells 2022-10-10 44 { ea8a55f838fb35 David Howells 2022-10-10 45 struct rxrpc_local *local; ea8a55f838fb35 David Howells 2022-10-10 46 struct sk_buff *skb; ea8a55f838fb35 David Howells 2022-10-10 47 ea8a55f838fb35 David Howells 2022-10-10 48 rcu_read_lock(); ea8a55f838fb35 David Howells 2022-10-10 49 local = rcu_dereference_sk_user_data(sk); ea8a55f838fb35 David Howells 2022-10-10 50 if (unlikely(!local)) { ea8a55f838fb35 David Howells 2022-10-10 51 rcu_read_unlock(); ea8a55f838fb35 David Howells 2022-10-10 @52 kfree_skb(skb); "skb" is uninitialized. ea8a55f838fb35 David Howells 2022-10-10 53 return; ea8a55f838fb35 David Howells 2022-10-10 54 } ea8a55f838fb35 David Howells 2022-10-10 55 ea8a55f838fb35 David Howells 2022-10-10 56 while ((skb = skb_dequeue(&sk->sk_error_queue))) { ea8a55f838fb35 David Howells 2022-10-10 57 skb->mark = RXRPC_SKB_MARK_ERROR; ea8a55f838fb35 David Howells 2022-10-10 58 rxrpc_new_skb(skb, rxrpc_skb_received); ea8a55f838fb35 David Howells 2022-10-10 59 skb_queue_tail(&local->rx_queue, skb); ea8a55f838fb35 David Howells 2022-10-10 60 } ea8a55f838fb35 David Howells 2022-10-10 61 ea8a55f838fb35 David Howells 2022-10-10 62 rxrpc_wake_up_io_thread(local); ea8a55f838fb35 David Howells 2022-10-10 63 rcu_read_unlock(); ea8a55f838fb35 David Howells 2022-10-10 64 } -- 0-DAY CI Kernel Test Service https://01.org/lkp