From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost.localdomain (unknown [182.253.183.240]) by gnuweeb.org (Postfix) with ESMTPSA id A587D816CA; Wed, 23 Nov 2022 12:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1669208039; bh=h0e0JzXCZRXQNtV2/YRT81wAEB+a4lz+1Ph/YPS2pZA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rjRDnsUyqje1XFruGHaLkm/SnEOS2Di0qBxqxC8b4hYcvYjR3XBpOhB5ZZzxCloyj Y3ezRHNBcBTE9tRr8NYmUEc39bf7sEN/wmula3BPkzy1YRMCrTzbt79IYtIlbDTmX/ LJt+PAv6QqDqnZCbJg+LvWgj9r/G62Nn25k4TcggifJmrsScFWQO7ZNM1MnqIG40Vf TIDClmtDowHQ/Y25V63jkqJR90oDh7217w9+2WpDi2P7/b0ElonoPxtnm3vtE+eChV 797GmKT/h2w+k6nRDG6erpodGni4Mbu8ooMIM9cN6R+Olh0AemSAMLwrruiHAXtoeQ 9aEPfWF3XMFwQ== From: Ammar Faizi To: Jens Axboe Cc: Pavel Begunkov , io-uring Mailing List , GNU/Weeb Mailing List , Muhammad Rizki , Alviro Iskandar Setiawan , Gilang Fachrezy , kernel@vnlx.org, Ammar Faizi Subject: [PATCH liburing v1 1/5] register: Remove useless branches in {un,}register eventfd Date: Wed, 23 Nov 2022 19:53:13 +0700 Message-Id: <20221123124922.3612798-2-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221123124922.3612798-1-ammar.faizi@intel.com> References: <20221123124922.3612798-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi IORING_{UN,}REGISTER_EVENTFD and IORING_REGISTER_EVENTFD_ASYNC don't return a positive value. These branches are useless. Remove them. [1]: io_eventfd_register [2]: io_eventfd_unregister Kernel-code-ref: https://github.com/torvalds/linux/blob/v6.1-rc6/io_uring/io_uring.c#L2511-L2547 [1] Kernel-code-ref: https://github.com/torvalds/linux/blob/v6.1-rc6/io_uring/io_uring.c#L2549-L2564 [2] Signed-off-by: Ammar Faizi --- src/register.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/src/register.c b/src/register.c index e849825..6cd607e 100644 --- a/src/register.c +++ b/src/register.c @@ -208,30 +208,21 @@ int io_uring_unregister_files(struct io_uring *ring) int io_uring_register_eventfd(struct io_uring *ring, int event_fd) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_EVENTFD, - &event_fd, 1); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_EVENTFD, + &event_fd, 1); } int io_uring_unregister_eventfd(struct io_uring *ring) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, IORING_UNREGISTER_EVENTFD, - NULL, 0); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, IORING_UNREGISTER_EVENTFD, + NULL, 0); } int io_uring_register_eventfd_async(struct io_uring *ring, int event_fd) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, - IORING_REGISTER_EVENTFD_ASYNC, &event_fd, - 1); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, + IORING_REGISTER_EVENTFD_ASYNC, &event_fd, + 1); } int io_uring_register_probe(struct io_uring *ring, struct io_uring_probe *p, -- Ammar Faizi