From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost.localdomain (unknown [182.253.183.240]) by gnuweeb.org (Postfix) with ESMTPSA id 0FCD8816E8; Wed, 23 Nov 2022 12:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1669208043; bh=9wtLnxSZR7iluiSivJYmlixu+O5bLsOm2cbIjp8hQpo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gpsfRyysxeY5Ae29j5hqT3vjOmXCNPRbyf2VDjbnc1gBVj6kKdkw3Not71NHAxhue KRxWwuMYXJlC8ONsdEf8SUuLS5ViuDnmVVcWlag5lYi39cooGnYujotF9o0YO+c85S P/RjoF8Pw8u8neqDRrPmF4Qo9jwKMDh95qKNY1QyVN6mEgjTYGmjEk0BK7KjC99Og6 Ww6p0VNI+71ddMeME5pU74KL084TrwNZLn4Em7TmWOsjL3GNf/oHVR9LlTbU3wlH98 XRVlcn5L3NGJ2sR3A4S6T16lKvAkwjwRXhjT/c4tctTW1MhOu3Re30ZRPo4pBdNa4s ALf05PcJIy+qQ== From: Ammar Faizi To: Jens Axboe Cc: Pavel Begunkov , io-uring Mailing List , GNU/Weeb Mailing List , Muhammad Rizki , Alviro Iskandar Setiawan , Gilang Fachrezy , kernel@vnlx.org, Ammar Faizi Subject: [PATCH liburing v1 2/5] register: Remove useless branches in {un,}register buffers Date: Wed, 23 Nov 2022 19:53:14 +0700 Message-Id: <20221123124922.3612798-3-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221123124922.3612798-1-ammar.faizi@intel.com> References: <20221123124922.3612798-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi IORING_REGISTER_BUFFERS and IORING_UNREGISTER_BUFFERS don't return a positive value. These bracnes are useless. Remove them. [1]: io_sqe_buffers_register [2]: io_sqe_buffers_unregister Kernel-code-ref: https://github.com/torvalds/linux/blob/v6.1-rc6/io_uring/rsrc.c#L1250-L1307 [1] Kernel-code-ref: https://github.com/torvalds/linux/blob/v6.1-rc6/io_uring/rsrc.c#L1036-L1054 [2] Signed-off-by: Ammar Faizi --- src/register.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/register.c b/src/register.c index 6cd607e..adb64cc 100644 --- a/src/register.c +++ b/src/register.c @@ -54,20 +54,14 @@ int io_uring_register_buffers_sparse(struct io_uring *ring, unsigned nr) int io_uring_register_buffers(struct io_uring *ring, const struct iovec *iovecs, unsigned nr_iovecs) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_BUFFERS, - iovecs, nr_iovecs); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_BUFFERS, + iovecs, nr_iovecs); } int io_uring_unregister_buffers(struct io_uring *ring) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, IORING_UNREGISTER_BUFFERS, - NULL, 0); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, IORING_UNREGISTER_BUFFERS, + NULL, 0); } int io_uring_register_files_update_tag(struct io_uring *ring, unsigned off, -- Ammar Faizi