From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost.localdomain (unknown [182.253.183.240]) by gnuweeb.org (Postfix) with ESMTPSA id 70E4B81642; Wed, 23 Nov 2022 12:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1669208048; bh=3fqkhmZgFdmIuypFqGHSrYYYxflG5WO0kGOle4KtvAk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o4ko4gKjs9lgXOyReOvpOAYSN8PBDGvkeM+MXBT5Yfzk30kJRvTpJSNfa80WBubeC dc8JmsI68PY6WOc8lG7PvC9bhffMHS32BhIDH4PTAHaar0En4r/YDBss8Ra+s4vBZG Qt+5mdq2i6H1oLqUz7tDAugqcPPmWzIK+rmsjBkAHG4fWQ93ugI675YdpTXWCJG+iO hDA1x+/ObzI2VzXbPYDwJmu/2MWX0a1FOD4LjlTsSF3ubxezejCDaqvE9X/C9MczSw lL7cM+8gCQhV3qMCuUG/tQcJbAh0sI0v43fd4rxasCccS7TbPHAnqzGMicvecwB/O1 njQpJJar2jARg== From: Ammar Faizi To: Jens Axboe Cc: Pavel Begunkov , io-uring Mailing List , GNU/Weeb Mailing List , Muhammad Rizki , Alviro Iskandar Setiawan , Gilang Fachrezy , kernel@vnlx.org, Ammar Faizi Subject: [PATCH liburing v1 3/5] register: Remove useless branch in unregister files Date: Wed, 23 Nov 2022 19:53:15 +0700 Message-Id: <20221123124922.3612798-4-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221123124922.3612798-1-ammar.faizi@intel.com> References: <20221123124922.3612798-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi IORING_UNREGISTER_FILES doesn't return a positive value. This branch is useless. Remove it. [1]: io_sqe_files_unregister Kernel-code-ref: https://github.com/torvalds/linux/blob/v6.1-rc6/io_uring/rsrc.c#L787-L805 [1] Signed-off-by: Ammar Faizi --- src/register.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/register.c b/src/register.c index adb64cc..c66f63e 100644 --- a/src/register.c +++ b/src/register.c @@ -193,11 +193,8 @@ int io_uring_register_files(struct io_uring *ring, const int *files, int io_uring_unregister_files(struct io_uring *ring) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, IORING_UNREGISTER_FILES, - NULL, 0); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, IORING_UNREGISTER_FILES, + NULL, 0); } int io_uring_register_eventfd(struct io_uring *ring, int event_fd) -- Ammar Faizi