From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from localhost.localdomain (unknown [182.253.183.240]) by gnuweeb.org (Postfix) with ESMTPSA id D0DF0816DC; Wed, 23 Nov 2022 12:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1669208052; bh=JK7/UCifqW8wTlavxsrzyY75SQ9viwdXe29FHFo0AQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FyyBq2oydhR3Kz9Z52H1d7pKqUwda8+nXClSqv8HltIPGRezDquhT4ukKeVWeutOu 0CzO7lDj6CAVfiOjfVFuPi4ktLzT470++nQ8X+FHRKeK53L16j6LjNfva6yAd3TTM2 EzeClH9J0yqWnfXKo8Y+HbLvaci0thu91POwHNtOrLjcABmEfFzDeA9/aX4BZDg/uV sdc6E8q/DElMj9SZnX11E/fmw+94i28+NGL4rbZpTVv3Y+gwnyF15oKaBcElt83iV2 gNMiuQz+mh8w6Zi3O0Mkcbyelb4vB+FwiqtOcmffe1qKc6i9l82rY66yybDhYUqviY LxBMdsFw2GFqA== From: Ammar Faizi To: Jens Axboe Cc: Pavel Begunkov , io-uring Mailing List , GNU/Weeb Mailing List , Muhammad Rizki , Alviro Iskandar Setiawan , Gilang Fachrezy , kernel@vnlx.org, Ammar Faizi Subject: [PATCH liburing v1 4/5] register: Remove useless branch in register probe Date: Wed, 23 Nov 2022 19:53:16 +0700 Message-Id: <20221123124922.3612798-5-ammar.faizi@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221123124922.3612798-1-ammar.faizi@intel.com> References: <20221123124922.3612798-1-ammar.faizi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Ammar Faizi IORING_REGISTER_PROBE doesn't return a positive value. This branch is useless. Remove it. [1]: io_probe Kernel-code-ref: https://github.com/torvalds/linux/blob/v6.1-rc6/io_uring/io_uring.c#L3608-L3646 [1] Signed-off-by: Ammar Faizi --- src/register.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/register.c b/src/register.c index c66f63e..6075f04 100644 --- a/src/register.c +++ b/src/register.c @@ -219,11 +219,8 @@ int io_uring_register_eventfd_async(struct io_uring *ring, int event_fd) int io_uring_register_probe(struct io_uring *ring, struct io_uring_probe *p, unsigned int nr_ops) { - int ret; - - ret = __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_PROBE, p, - nr_ops); - return (ret < 0) ? ret : 0; + return __sys_io_uring_register(ring->ring_fd, IORING_REGISTER_PROBE, p, + nr_ops); } int io_uring_register_personality(struct io_uring *ring) -- Ammar Faizi