From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NO_DNS_FOR_FROM,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.6
Received: from localhost.localdomain (unknown [182.253.183.240])
	by gnuweeb.org (Postfix) with ESMTPSA id 8155F81735;
	Thu, 24 Nov 2022 16:29:43 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1669307387;
	bh=mEI6HC5l2sBw24fjcNUAA4bUPzG2/JQPzrbzIlLPK4g=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
	b=RiPz2yf3kXTFTRgy3NC3HG7IY7oGAX45jCqBG2EQ0ApxuxNVkwotFznfsFvW02wV9
	 AoZ5q7ZKFEKHTQ+Qf2YDEOMfbuxd6HILpneD+cnfWQ2qYD6RivR/eY6xUbHnNP7B2F
	 8GeTha1tU3b/MyQZtB/IkfU9avfC89PFJ6JoEu76guYqdlfhpfQKoTalHNxrqlGLI3
	 XSYs6A7EXVTVvQHKpvGbG3bE6Uf0/3VpDPfyLyK2G7ytiL7Wr9St2JtselcMeRgB++
	 XCSsBULXsf9MtWDoxvxSPiQw8jtVWmaduknBGqNiCy1kLuftwozNCxWuawyBN58rm8
	 zn3wWSKtJupZg==
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	Dylan Yudaken <dylany@meta.com>,
	Pavel Begunkov <asml.silence@gmail.com>,
	Gilang Fachrezy <gilang4321@gmail.com>,
	Muhammad Rizki <kiizuha@gnuweeb.org>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	VNLX Kernel Department <kernel@vnlx.org>,
	io-uring Mailing List <io-uring@vger.kernel.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: [PATCH liburing v2 8/8] github: Add `-Wmissing-prototypes` for GitHub CI bot
Date: Thu, 24 Nov 2022 23:29:01 +0700
Message-Id: <20221124162633.3856761-9-ammar.faizi@intel.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221124162633.3856761-1-ammar.faizi@intel.com>
References: <20221124162633.3856761-1-ammar.faizi@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <gwml.vger.gnuweeb.org>

From: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Using -Wmissing-prototypes ensures we mark functions and variables as
static if we don't use them outside the translation unit.

Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
---
 .github/workflows/build.yml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index b0e669d..4c0bd26 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -26,7 +26,8 @@ jobs:
             cxx_pkg: clang
             cc: clang
             cxx: clang++
-            extra_flags: -Wshorten-64-to-32
+            liburing_extra_flags: -Wshorten-64-to-32
+            extra_flags: -Wmissing-prototypes
 
           # x86 (32-bit) gcc
           - arch: i686
@@ -85,10 +86,10 @@ jobs:
             cxx: mips-linux-gnu-g++
 
     env:
-      FLAGS: -g -O3 -Wall -Wextra -Werror
+      FLAGS: -g -O3 -Wall -Wextra -Werror ${{matrix.extra_flags}}
 
       # Flags for building sources in src/ dir only.
-      LIBURING_CFLAGS: ${{matrix.extra_flags}}
+      LIBURING_CFLAGS: ${{matrix.liburing_extra_flags}}
 
     steps:
     - name: Checkout source
-- 
Ammar Faizi