public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: Willy Tarreau <[email protected]>, Shuah Khan <[email protected]>,
	"Paul E. McKenney" <[email protected]>
Cc: Ammar Faizi <[email protected]>,
	Gilang Fachrezy <[email protected]>,
	VNLX Kernel Department <[email protected]>,
	Alviro Iskandar Setiawan <[email protected]>,
	Kanna Scarlet <[email protected]>,
	Muhammad Rizki <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	Linux Kernel Mailing List <[email protected]>,
	Linux Kselftest Mailing List <[email protected]>
Subject: [RFC PATCH v1 0/8] nolibc signal handling support
Date: Thu, 22 Dec 2022 10:51:26 +0700	[thread overview]
Message-ID: <[email protected]> (raw)

From: Ammar Faizi <[email protected]>

Hi,

This series adds signal handling support to the nolibc subsystem.

1)  Initial implementation of nolibc sigaction(2) function.

    Currently, this implementation is only available on the x86-64 arch.

    sigaction() needs an architecture-dependent "signal trampoline"
    function that invokes the __rt_sigreturn syscall to resume the process
    after a signal gets handled.

    On Linux x86-64, the "signal trampoline" function has to be written in
    inline Assembly to prevent the compiler from controlling the %rsp
    (e.g., with -fno-omit-frame-pointer, every function has a pushq
    %rbp that makes the %rsp no longer point to struct rt_sigframe).

    The "signal trampoline" function is called __arch_restore_rt in this
    implementation.

2)  signal(2) function.

    signal() function is the simpler version of sigaction(). Unlike
    sigaction(), which fully controls the struct sigaction, the caller
    only cares about the sa_handler when calling the signal() function.

    signal() internally calls sigaction(). This implementation is
    currently only available on the x86-64 arch. When the sigaction()
    function support is expanded to other architectures, this function
    will automatically support those architectures. It's basically just
    a sigaction() wrapper.

3)  Extra nolibc updates.

    Apart from the signal handling support. This series also contains
    nolibc updates, they are:

      - getpagesize() support.
      - CFLAGS update.
      - fork(2) selftest.
      - sigaction(2) selftest.
      - signal(2) selftest.
      - getpagesize(2) selftest.

There 8 patches in this series. It has been tested on Linux x86-64 arch
and all tests OK.

    $ sudo ./nolibc-test
    Running test 'syscall'
    ...
    ...
    66 wait_child = -1 ECHILD                [OK]
    67 waitpid_min = -1 ESRCH                [OK]
    68 waitpid_child = -1 ECHILD             [OK]
    69 write_badf = -1 EBADF                 [OK]
    70 write_zero = 0                        [OK]
    Errors during this test: 0


    Running test 'stdlib'
    ...
    ...
    14 memcmp_60_20 = 64                     [OK]
    15 memcmp_20_e0 = -192                   [OK]
    16 memcmp_e0_20 = 192                    [OK]
    17 memcmp_80_e0 = -96                    [OK]
    18 memcmp_e0_80 = 96                     [OK]
    Errors during this test: 0

    Total number of errors: 0
    Exiting with status 0

    $ make run -j8
    Kernel: arch/x86/boot/bzImage is ready  (#3)
    ...
    82 test(s) passed.

Signed-off-by: Ammar Faizi <[email protected]>
---

It's also available in the Git repository.

The following changes since commit caf5c36025ec9395c8d7c78957b016a284812d23:

  srcu: Update comment after the index flip (2022-12-21 09:01:53 -0800)

are available in the Git repository at:

  https://github.com/ammarfaizi2/linux-block testing/rfc.v1.2022-12-22.nolibc

for you to fetch changes up to ac79aca684125907bfbefadfd6c6be0ccdfe8b33:

  selftests/nolibc: Add `getpagesize(2)` selftest (2022-12-22 09:57:31 +0700)

----------------------------------------------------------------
Ammar Faizi (8):
    nolibc/sys: Implement `sigaction(2)` function
    nolibc/sys: Implement `signal(2)` function
    nolibc/sys: Implement `getpagesize(2)` function
    selftests/nolibc: Add `-Wall` and `-Wno-unsed-function` to the CFLAGS
    selftests/nolibc: Add `fork(2)` selftest
    selftests/nolibc: Add `sigaction(2)` selftest
    selftests/nolibc: Add `signal(2)` selftest
    selftests/nolibc: Add `getpagesize(2)` selftest

 tools/include/nolibc/arch-x86_64.h           |  12 +
 tools/include/nolibc/sys.h                   | 224 +++++++++++++++++++
 tools/testing/selftests/nolibc/Makefile      |   2 +-
 tools/testing/selftests/nolibc/nolibc-test.c | 219 +++++++++++++++++-
 4 files changed, 454 insertions(+), 3 deletions(-)


base-commit: caf5c36025ec9395c8d7c78957b016a284812d23
-- 
Ammar Faizi


             reply	other threads:[~2022-12-22  3:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22  3:51 Ammar Faizi [this message]
2022-12-22  3:51 ` [RFC PATCH v1 1/8] nolibc/sys: Implement `sigaction(2)` function Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 2/8] nolibc/sys: Implement `signal(2)` function Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 3/8] nolibc/sys: Implement `getpagesize(2)` function Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 4/8] selftests/nolibc: Add `-Wall` and `-Wno-unsed-function` to the CFLAGS Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 5/8] selftests/nolibc: Add `fork(2)` selftest Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 6/8] selftests/nolibc: Add `sigaction(2)` selftest Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 7/8] selftests/nolibc: Add `signal(2)` selftest Ammar Faizi
2022-12-22  3:51 ` [RFC PATCH v1 8/8] selftests/nolibc: Add `getpagesize(2)` selftest Ammar Faizi
2022-12-22  4:34 ` [RFC PATCH v1 0/8] nolibc signal handling support Willy Tarreau
2022-12-22 13:46   ` Ammar Faizi
2022-12-22 14:55     ` Alviro Iskandar Setiawan
2022-12-27  6:26     ` Willy Tarreau
2022-12-27 13:32       ` Ammar Faizi
2022-12-27 13:36         ` Ammar Faizi
2022-12-27 18:58           ` Willy Tarreau
2022-12-28 12:23             ` Ammar Faizi
2022-12-27 18:49         ` Willy Tarreau
2022-12-28 12:01           ` Ammar Faizi
2022-12-28 13:35             ` Willy Tarreau
2022-12-29 11:41               ` Ammar Faizi
2023-01-03  3:51                 ` Alviro Iskandar Setiawan
2023-01-03  3:54                   ` Willy Tarreau
2023-01-03  3:59                     ` Ammar Faizi
2023-01-08 13:08                       ` [PATCH v1 0/3] nolibc auxiliary vector retrieval support Ammar Faizi
2023-01-08 13:08                         ` [PATCH v1 1/3] nolibc/stdlib: Implement `getauxval(3)` function Ammar Faizi
2023-01-08 13:08                         ` [PATCH v1 2/3] nolibc/sys: Implement `getpagesize(2)` function Ammar Faizi
2023-01-08 13:08                         ` [PATCH v1 3/3] selftests/nolibc: Add `getpagesize(2)` selftest Ammar Faizi
2023-01-08 13:10                       ` [PATCH v2 0/4] nolibc signal handling support Ammar Faizi
2023-01-08 13:10                         ` [PATCH v2 1/4] nolibc/sys: Implement `sigaction(2)` function Ammar Faizi
2023-01-08 13:10                         ` [PATCH v2 2/4] nolibc/sys: Implement `signal(2)` function Ammar Faizi
2023-01-08 13:10                         ` [PATCH v2 3/4] selftests/nolibc: Add `fork(2)` selftest Ammar Faizi
2023-01-08 13:10                         ` [PATCH v2 4/4] selftests/nolibc: Add `sigaction(2)` selftest Ammar Faizi
2023-01-08 13:28                         ` [PATCH v2 0/4] nolibc signal handling support Alviro Iskandar Setiawan
2023-01-08 13:31                           ` Ammar Faizi
2023-01-08 13:39                             ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox