Re: [ammarfaizi2-block:akpm/mm/mm-unstable 187/223] mm/nommu.c:547:6: warning: no previous prototype for function 'vma_mas_store'

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 6 Jan 2023 23:02:44 +0800 kernel test robot <lkp@intel.com> wrote:

> tree:   https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable
> head:   a2765ca8c916591ebc9af48b4e545922c0bd3c3b
> commit: c9f5ce5be2dfd3e5d5f36cac50b93c86982fcabc [187/223] mmap: convert __vma_adjust() to use vma iterator
> config: arm-randconfig-r004-20230106
> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 8d9828ef5aa9688500657d36cd2aefbe12bbd162)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm cross compiling tool for clang build
>         # apt-get install binutils-arm-linux-gnueabi
>         # https://github.com/ammarfaizi2/linux-block/commit/c9f5ce5be2dfd3e5d5f36cac50b93c86982fcabc
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block akpm/mm/mm-unstable
>         git checkout c9f5ce5be2dfd3e5d5f36cac50b93c86982fcabc
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> mm/nommu.c:547:6: warning: no previous prototype for function 'vma_mas_store' [-Wmissing-prototypes]
>    void vma_mas_store(struct vm_area_struct *vma, struct ma_state *mas)
>         ^

Thanks.  I'll do this for now, as a temp thing.

--- a/mm/nommu.c~mmap-convert-__vma_adjust-to-use-vma-iterator-fix
+++ a/mm/nommu.c
@@ -544,7 +544,7 @@ static void put_nommu_region(struct vm_r
 	__put_nommu_region(region);
 }
 
-void vma_mas_store(struct vm_area_struct *vma, struct ma_state *mas)
+static void vma_mas_store(struct vm_area_struct *vma, struct ma_state *mas)
 {
 	mas_set_range(mas, vma->vm_start, vma->vm_end - 1);
 	mas_store_prealloc(mas, vma);
_