From: Ammar Faizi <[email protected]>
To: Willy Tarreau <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Shuah Khan <[email protected]>,
"Paul E. McKenney" <[email protected]>,
Gilang Fachrezy <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
Linux Kselftest Mailing List <[email protected]>
Subject: [PATCH v3 4/5] selftests/nolibc: Add `sigaction(2)` selftest
Date: Sun, 8 Jan 2023 20:59:03 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
From: Ammar Faizi <[email protected]>
Test the sigaction() function implementation. Test steps:
- Set a signal handler.
- Then send a signal to itself using the kill() syscall.
- The program has to survive and store the caught signal number in a
volatile global variable.
- Validate the volatile global variable value.
- Restore the original signal handler.
Signed-off-by: Ammar Faizi <[email protected]>
---
tools/testing/selftests/nolibc/nolibc-test.c | 73 ++++++++++++++++++++
1 file changed, 73 insertions(+)
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index cb6ec9f71aae..c348c92d26f6 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -515,6 +515,78 @@ static int test_fork(void)
return 0;
}
+static volatile int g_test_sig;
+
+static void test_signal_handler(int sig)
+{
+ g_test_sig = sig;
+}
+
+static int test_sigaction_sig(int sig)
+{
+ const struct sigaction new = {
+ .sa_handler = test_signal_handler
+ };
+ struct sigaction old;
+ int ret;
+
+ /*
+ * Set the signal handler.
+ */
+ ret = sigaction(sig, &new, &old);
+ if (ret) {
+ printf("test_sigaction_sig(%d): Failed to set a signal handler\n", sig);
+ return ret;
+ }
+
+ /*
+ * Test the signal handler.
+ */
+ g_test_sig = 0;
+ kill(getpid(), sig);
+
+ /*
+ * test_signal_handler() must set @g_test_sig to @sig.
+ */
+ if (g_test_sig != sig) {
+ printf("test_sigaction_sig(%d): Invalid g_test_sig value (%d != %d)\n", sig, g_test_sig, sig);
+ return -1;
+ }
+
+ /*
+ * Restore the original signal handler.
+ */
+ ret = sigaction(sig, &old, NULL);
+ if (ret) {
+ printf("test_sigaction_sig(%d): Failed to restore the signal handler\n", sig);
+ return ret;
+ }
+
+ return 0;
+}
+
+static const int g_sig_to_test[] = {
+ SIGINT,
+ SIGHUP,
+ SIGTERM,
+ SIGQUIT,
+ SIGSEGV
+};
+
+static int test_sigaction(void)
+{
+ size_t i;
+ int ret;
+
+ for (i = 0; i < (sizeof(g_sig_to_test) / sizeof(g_sig_to_test[0])); i++) {
+ ret = test_sigaction_sig(g_sig_to_test[i]);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+
/* Run syscall tests between IDs <min> and <max>.
* Return 0 on success, non-zero on failure.
*/
@@ -596,6 +668,7 @@ int run_syscall(int min, int max)
CASE_TEST(select_null); EXPECT_SYSZR(1, ({ struct timeval tv = { 0 }; select(0, NULL, NULL, NULL, &tv); })); break;
CASE_TEST(select_stdout); EXPECT_SYSNE(1, ({ fd_set fds; FD_ZERO(&fds); FD_SET(1, &fds); select(2, NULL, &fds, NULL, NULL); }), -1); break;
CASE_TEST(select_fault); EXPECT_SYSER(1, select(1, (void *)1, NULL, NULL, 0), -1, EFAULT); break;
+ CASE_TEST(sigaction); EXPECT_SYSZR(1, test_sigaction()); break;
CASE_TEST(stat_blah); EXPECT_SYSER(1, stat("/proc/self/blah", &stat_buf), -1, ENOENT); break;
CASE_TEST(stat_fault); EXPECT_SYSER(1, stat(NULL, &stat_buf), -1, EFAULT); break;
CASE_TEST(symlink_root); EXPECT_SYSER(1, symlink("/", "/"), -1, EEXIST); break;
--
Ammar Faizi
next prev parent reply other threads:[~2023-01-08 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 13:58 [PATCH v3 0/5] nolibc signal handling support Ammar Faizi
2023-01-08 13:59 ` [PATCH v3 1/5] nolibc/sys: Implement `sigaction(2)` function Ammar Faizi
2023-01-08 13:59 ` [PATCH v3 2/5] nolibc/sys: Implement `signal(2)` function Ammar Faizi
2023-01-08 13:59 ` [PATCH v3 3/5] selftests/nolibc: Add `fork(2)` selftest Ammar Faizi
2023-01-08 13:59 ` Ammar Faizi [this message]
2023-01-08 13:59 ` [PATCH v3 5/5] selftests/nolibc: Add `signal(2)` selftest Ammar Faizi
2023-01-08 17:58 ` [PATCH v3 0/5] nolibc signal handling support Willy Tarreau
2023-01-08 18:31 ` Ammar Faizi
2023-01-08 18:49 ` Willy Tarreau
2023-01-15 16:01 ` Ammar Faizi
2023-01-15 17:06 ` Alviro Iskandar Setiawan
2023-01-17 23:17 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox