From: kernel test robot <[email protected]>
To: Ammar Faizi <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Cc: [email protected]
Subject: [ammarfaizi2-block:google/android/kernel/common/android12-5.10 1/1] drivers/usb/gadget/function/f_accessory.c:1088:5: warning: no previous prototype for 'acc_ctrlrequest_composite'
Date: Sat, 21 Jan 2023 04:30:15 +0800 [thread overview]
Message-ID: <[email protected]> (raw)
tree: https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android12-5.10
head: e12e360999d84e5e56952c6c027803f662567d76
commit: e12e360999d84e5e56952c6c027803f662567d76 [1/1] ANDROID: usb: f_accessory: Check buffer size when initialised via composite
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20230121/[email protected]/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/e12e360999d84e5e56952c6c027803f662567d76
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android12-5.10
git checkout e12e360999d84e5e56952c6c027803f662567d76
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/usb/gadget/function/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
All warnings (new ones prefixed by >>):
drivers/usb/gadget/function/f_accessory.c:975:5: warning: no previous prototype for 'acc_ctrlrequest' [-Wmissing-prototypes]
975 | int acc_ctrlrequest(struct usb_composite_dev *cdev,
| ^~~~~~~~~~~~~~~
>> drivers/usb/gadget/function/f_accessory.c:1088:5: warning: no previous prototype for 'acc_ctrlrequest_composite' [-Wmissing-prototypes]
1088 | int acc_ctrlrequest_composite(struct usb_composite_dev *cdev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/gadget/function/f_accessory.c:1441:6: warning: no previous prototype for 'acc_disconnect' [-Wmissing-prototypes]
1441 | void acc_disconnect(void)
| ^~~~~~~~~~~~~~
drivers/usb/gadget/function/f_accessory.c:1546:5: warning: no previous prototype for 'acc_ctrlrequest_configfs' [-Wmissing-prototypes]
1546 | int acc_ctrlrequest_configfs(struct usb_function *f,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/acc_ctrlrequest_composite +1088 drivers/usb/gadget/function/f_accessory.c
1087
> 1088 int acc_ctrlrequest_composite(struct usb_composite_dev *cdev,
1089 const struct usb_ctrlrequest *ctrl)
1090 {
1091 u16 w_length = le16_to_cpu(ctrl->wLength);
1092
1093 if (w_length > USB_COMP_EP0_BUFSIZ) {
1094 if (ctrl->bRequestType & USB_DIR_IN) {
1095 /* Cast away the const, we are going to overwrite on purpose. */
1096 __le16 *temp = (__le16 *)&ctrl->wLength;
1097
1098 *temp = cpu_to_le16(USB_COMP_EP0_BUFSIZ);
1099 w_length = USB_COMP_EP0_BUFSIZ;
1100 } else {
1101 return -EINVAL;
1102 }
1103 }
1104 return acc_ctrlrequest(cdev, ctrl);
1105 }
1106 EXPORT_SYMBOL_GPL(acc_ctrlrequest_composite);
1107
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-01-20 20:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox