[ammarfaizi2-block:viro/vfs/work.minix 3/4] fs/sysv/dir.c:32: multiple definition of `dir_put_page'; fs/minix/dir.o:fs/minix/dir.c:30: first defined here

[ammarfaizi2-block:viro/vfs/work.minix 3/4] fs/sysv/dir.c:32: multiple definition of `dir_put_page'; fs/minix/dir.o:fs/minix/dir.c:30: first defined here

[kernel test robot]

tree:   https://github.com/ammarfaizi2/linux-block viro/vfs/work.minix
head:   39d0d7f9b65f1fe91c5ba6d375f1ddb0c34fe843
commit: b7176563af9725b556c512d0fee2dbd051839147 [3/4] minixfs: Use dir_put_page() in minix_unlink() and minix_rename()
config: i386-randconfig-a005-20230306 (https://download.01.org/0day-ci/archive/20230307/202303071352.h8Mj6c0x-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/ammarfaizi2/linux-block/commit/b7176563af9725b556c512d0fee2dbd051839147
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block viro/vfs/work.minix
        git checkout b7176563af9725b556c512d0fee2dbd051839147
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 olddefconfig
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303071352.h8Mj6c0x-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: fs/sysv/dir.o: in function `dir_put_page':
>> fs/sysv/dir.c:32: multiple definition of `dir_put_page'; fs/minix/dir.o:fs/minix/dir.c:30: first defined here


vim +32 fs/sysv/dir.c

^1da177e4c3f415 Linus Torvalds        2005-04-16  30  
83005276d383387 Fabio M. De Francesco 2023-01-19  31  inline void dir_put_page(struct page *page, void *page_addr)
^1da177e4c3f415 Linus Torvalds        2005-04-16 @32  {
83005276d383387 Fabio M. De Francesco 2023-01-19  33  	kunmap_local((void *)((unsigned long)page_addr & PAGE_MASK));
09cbfeaf1a5a67b Kirill A. Shutemov    2016-04-01  34  	put_page(page);
^1da177e4c3f415 Linus Torvalds        2005-04-16  35  }
^1da177e4c3f415 Linus Torvalds        2005-04-16  36  

:::::: The code at line 32 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

Re: [ammarfaizi2-block:viro/vfs/work.minix 3/4] fs/sysv/dir.c:32: multiple definition of `dir_put_page'; fs/minix/dir.o:fs/minix/dir.c:30: first defined here

[Al Viro]

On Tue, Mar 07, 2023 at 01:13:55PM +0800, kernel test robot wrote:
> tree:   https://github.com/ammarfaizi2/linux-block viro/vfs/work.minix
> head:   39d0d7f9b65f1fe91c5ba6d375f1ddb0c34fe843
> commit: b7176563af9725b556c512d0fee2dbd051839147 [3/4] minixfs: Use dir_put_page() in minix_unlink() and minix_rename()
> config: i386-randconfig-a005-20230306 (https://download.01.org/0day-ci/archive/20230307/202303071352.h8Mj6c0x-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/ammarfaizi2/linux-block/commit/b7176563af9725b556c512d0fee2dbd051839147
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block viro/vfs/work.minix
>         git checkout b7176563af9725b556c512d0fee2dbd051839147
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 olddefconfig
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303071352.h8Mj6c0x-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    ld: fs/sysv/dir.o: in function `dir_put_page':
> >> fs/sysv/dir.c:32: multiple definition of `dir_put_page'; fs/minix/dir.o:fs/minix/dir.c:30: first defined here

Grrr...  FWIW, it ought to be static inline in both of them,
and quite likely - moved over to some place like highmem.h.

put_and_unmap_page(page, addr), perhaps?