public inbox for [email protected]
 help / color / mirror / Atom feed
From: Ammar Faizi <[email protected]>
To: GNU/Weeb FB Team <[email protected]>
Cc: Ammar Faizi <[email protected]>,
	GNU/Weeb Mailing List <[email protected]>,
	Michael William Jonathan <[email protected]>
Subject: [PATCH fb v1 3/6] fb: Post: Implement cache in `getPost()`
Date: Tue,  9 May 2023 17:46:55 +0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Make short repeated calls fast.

Signed-off-by: Ammar Faizi <[email protected]>
---
 src/Facebook/Methods/Post.php | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/Facebook/Methods/Post.php b/src/Facebook/Methods/Post.php
index 81017c9122e6c341..3cf5d7e9896e74ce 100644
--- a/src/Facebook/Methods/Post.php
+++ b/src/Facebook/Methods/Post.php
@@ -353,6 +353,13 @@ trait Post
 	 */
 	public function getPost(string $post_id): array
 	{
+		$cacheKey = __METHOD__.$post_id;
+
+		$ret = $this->getCache($cacheKey);
+		if ($ret) {
+			return $ret;
+		}
+
 		/**
 		 * $post_id must be numeric or a string starts with "pfbid".
 		 */
@@ -372,9 +379,11 @@ trait Post
 		$content = $this->parsePostContent($o);
 		$content["embedded_link"] = $this->parseEmbeddedLink($orig);
 
-		return [
+		$ret = [
 			"content" => $content,
 			"info"    => $info
 		];
+		$this->setCache($cacheKey, $ret);
+		return $ret;
 	}
 }
-- 
Ammar Faizi


  parent reply	other threads:[~2023-05-09 10:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 10:46 [PATCH fb v1 0/6] Introducing cache for the Facebook scraper Ammar Faizi
2023-05-09 10:46 ` [PATCH fb v1 1/6] fb: Introduce `getCache()` and `setCache()` functions Ammar Faizi
2023-05-09 10:46 ` [PATCH fb v1 2/6] fb: Post: Replace old cache mechanism in `getTimelineYears()` Ammar Faizi
2023-05-09 10:46 ` Ammar Faizi [this message]
2023-05-09 10:46 ` [PATCH fb v1 4/6] fb: Post: Implement cache in `getTimelinePosts()` Ammar Faizi
2023-05-09 10:46 ` [PATCH fb v1 5/6] fb: cache: Introduce `clearExpiredCaches()` Ammar Faizi
2023-05-09 10:46 ` [PATCH fb v1 6/6] fb: web: Create cron.php to clear cache Ammar Faizi
2023-05-09 11:06 ` [PATCH fb v1 0/6] Introducing cache for the Facebook scraper GNU/Weeb Facebook Team

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox