From: Ammar Faizi <[email protected]>
To: GNU/Weeb Mailing List <[email protected]>
Cc: Ammar Faizi <[email protected]>,
Michael William Jonathan <[email protected]>,
Nicholas Rosenberg <[email protected]>,
GNU/Weeb Facebook Team <[email protected]>,
VNLX Kernel Department <[email protected]>
Subject: [PATCH fb v1 0/3] A small bug fix for the mbasic changes
Date: Thu, 29 Jun 2023 02:58:25 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
Hi,
Michael reports that using the recent API, photo contents in the
HonkaiStarRail.ID timeline are detected as a "text".
Using the current parser, it detects those contents as a text with a
link preview (where the preview is the post to the photo). Let's just
visit the photo link if there exists before continue trying to parse
it as a photo. Also, make sure we try to parse as a photo first before
text.
There are 3 patches in this series. The first and the second patches
are just a simple tweak and clean up. The third patch is the fix to
the serious issue.
Patch 1:
The getCache() function doesn't take the expiration date into account.
Make sure it does.
Patch 2:
I often generate patch files in the same directory with the project
directory. I don't want to commit them. Add '*.patch' to .gitignore to
avoid that.
Patch 3:
The fix that's explained in the introduction.
Signed-off-by: Ammar Faizi <[email protected]>
---
The following changes since commit dbc3dfcc32af4b934c0ace3dd7efbfe9878f133f:
Merge branch 'dev.fast_asset' (Facebook Onion assets optimization) (2023-05-13 02:01:05 +0700)
are available in the Git repository at:
https://gitlab.torproject.org/ammarfaizi2/Facebook.git dev
for you to fetch changes up to 0a1c38b9315cad0c6149c17beffae514d0ab93d5:
fb: Post: Fix the wrong content type detection (photo issue) (2023-06-25 13:58:47 +0700)
----------------------------------------------------------------
Ammar Faizi (3):
fb: Fix `getCache()` expiration logic handling
fb: .gitignore: Ignore *.patch files
fb: Post: Fix the wrong content type detection (photo issue)
.gitignore | 3 ++-
src/Facebook/Facebook.php | 5 +++++
src/Facebook/Methods/Post.php | 9 +++++++--
3 files changed, 14 insertions(+), 3 deletions(-)
base-commit: dbc3dfcc32af4b934c0ace3dd7efbfe9878f133f
--
Ammar Faizi
next reply other threads:[~2023-06-28 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 19:58 Ammar Faizi [this message]
2023-06-28 19:58 ` [PATCH fb v1 1/3] fb: Fix `getCache()` expiration logic handling Ammar Faizi
2023-06-28 19:58 ` [PATCH fb v1 2/3] fb: .gitignore: Ignore *.patch files Ammar Faizi
2023-06-28 19:58 ` [PATCH fb v1 3/3] fb: Post: Fix the wrong content type detection (photo issue) Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox