From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1740781499; bh=+c8MGm71jDj7p0YJcCehFVIbrw1FxVko6e+wFihPPKc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version: Content-Transfer-Encoding:Message-ID:Date:From:Reply-To:Subject:To: Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To: Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding; b=kYLkJKQHpUbeGHRSblYA/E06KBp0oa6/TW7YjYX3szKFoM7bREj+NQVDE6e1/Tlby HrtDsAdntjOwPbhxxghBlzxljSpbjrAh3iGPRZOd5qwce+pg30fHG4JfC1S/LOvo06 PjIiin6igoWzvOQKTd6eErtNlxAxX4EpjrMxhdczof/ajYrqQ2JvBOr4uf40K1LiWn G+tOQQxOtRL1Cyj9q5Mg1+R5mxU1RyzCO8BIYTBayIysx5j118nsuSGKXEbLk9tr3e bfCeFWbp0HkvzckVmJ8ZibKLkLVDSHRU/ux3vS7VK5OohUsIdWfcYaJA7gj6A4AM8K i2Aua78CvH+WA== Received: from integral2.. (unknown [182.253.126.171]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 3FA202071A2C; Fri, 28 Feb 2025 22:24:56 +0000 (UTC) From: Ammar Faizi To: GNU/Weeb Mailing List Cc: Muhammad Rizki , Alviro Iskandar Setiawan , "M. Taufiq Hidayat Pohan" , Ammar Faizi Subject: [PATCH] helpers2: Change 'INNER JOIN' to 'LEFT JOIN' Date: Sat, 1 Mar 2025 05:24:50 +0700 Message-Id: <20250228222450.1587857-1-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Taufiq reported that he was unable to login via the new interface. After some debugging, it turned out the login query was returning an empty result-set because Taufiq did not have an entry in the "user_info" table and the query was using an "INNER JOIN" to fetch the user's information. Let's just fill the missing entry with NULL values by using "LEFT JOIN". If the user changes his/her information, the entry will be updated accordingly. Reported-by: M. Taufiq Hidayat Pohan Signed-off-by: Ammar Faizi --- storage/gwmail-web/mail.gnuweeb.org/src/helpers2.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/storage/gwmail-web/mail.gnuweeb.org/src/helpers2.php b/storage/gwmail-web/mail.gnuweeb.org/src/helpers2.php index 66ba13538464..98ddac967d11 100644 --- a/storage/gwmail-web/mail.gnuweeb.org/src/helpers2.php +++ b/storage/gwmail-web/mail.gnuweeb.org/src/helpers2.php @@ -374,7 +374,7 @@ function gwm_get_user_full(PDO $pdo, int $user_id): ?array $fields .= "`user_info`.`{$f}`, "; $fields = substr($fields, 0, -2); - $st = $pdo->prepare("SELECT {$fields} FROM `users` INNER JOIN `user_info` ON `users`.`id` = `user_info`.`user_id` WHERE `users`.`id` = ? LIMIT 1;"); + $st = $pdo->prepare("SELECT {$fields} FROM `users` LEFT JOIN `user_info` ON `users`.`id` = `user_info`.`user_id` WHERE `users`.`id` = ? LIMIT 1;"); $st->execute([$user_id]); $u = $st->fetch(PDO::FETCH_ASSOC); if (!$u) -- Ammar Faizi