From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1741375606; bh=aVrWpbKtTSVkbnVZUARHIEU9LCo1Uw1ioSO2fQtfPgU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=JTVKGsUoSvflu92kx+OeAW2cjAa0wFu/bxv8lzxLqI8ZpM1QlmDp030+5SVj/680X O/V0v+v63lk3qi3p6H2c7yptlgWuBn3ju6dxKOFSIJtlcoZIqg3Qu4WAEH8veRBUCx yAJ/fn5gYYITnzMeyrRkM8X1tNAet4SRy/M9lpeJlvc+Gi8aueOrLe3qpAiZcVySUr VuhMOE2VfIsDVGwnYyc5X+WgVYLPDHtodrgxungpZWQVQOsSaFf4I5vytZFJ42G2G1 Yc9nfn60UCQvDYT2JTUeL9J9DRSo3VqI9oW/Gx9dsvjGzKbJye1URJ7djrY75gvqBB ZM6vhYp2bwrYg== Received: from localhost.localdomain (unknown [101.128.125.112]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id C2FD320B48E3; Fri, 7 Mar 2025 19:26:45 +0000 (UTC) From: Muhammad Rizki To: Ammar Faizi Cc: Muhammad Rizki , Alviro Iskandar Setiawan , GNU/Weeb Mailing List Subject: [PATCH v1 04/10] fix(profile): make social fields default to empty string Date: Sat, 8 Mar 2025 02:26:14 +0700 Message-ID: <20250307192622.1172-5-kiizuha@gnuweeb.org> X-Mailer: git-send-email 2.45.2.windows.1 In-Reply-To: <20250307192622.1172-1-kiizuha@gnuweeb.org> References: <20250307192622.1172-1-kiizuha@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Previously, is optional but doesn't have default value for it. This commit adds default value for social fields to empty string to prevent null value. Signed-off-by: Muhammad Rizki --- src/lib/schemas/profile-schema.ts | 8 ++-- .../(protected)/settings/profile/+page.svelte | 38 ++++++++----------- 2 files changed, 20 insertions(+), 26 deletions(-) diff --git a/src/lib/schemas/profile-schema.ts b/src/lib/schemas/profile-schema.ts index c4c7228..a9981f1 100644 --- a/src/lib/schemas/profile-schema.ts +++ b/src/lib/schemas/profile-schema.ts @@ -13,10 +13,10 @@ export const profileSchema = z.object({ ext_email: z.string().email("Invalid email format"), gender: z.enum(["m", "f"]), socials: z.object({ - github_username: z.string().optional(), - telegram_username: z.string().optional(), - twitter_username: z.string().optional(), - discord_username: z.string().optional() + github_username: z.string().optional().default(""), + telegram_username: z.string().optional().default(""), + twitter_username: z.string().optional().default(""), + discord_username: z.string().optional().default("") }), password: z.string() }); diff --git a/src/routes/(protected)/settings/profile/+page.svelte b/src/routes/(protected)/settings/profile/+page.svelte index 5ddac3b..2e9b76f 100644 --- a/src/routes/(protected)/settings/profile/+page.svelte +++ b/src/routes/(protected)/settings/profile/+page.svelte @@ -41,18 +41,10 @@ formData.append("ext_email", form.data.ext_email); formData.append("gender", form.data.gender); formData.append("password", form.data.password); - if (form.data.socials.github_username) { - formData.append("socials[github_username]", form.data.socials.github_username); - } - if (form.data.socials.telegram_username) { - formData.append("socials[telegram_username]", form.data.socials.telegram_username); - } - if (form.data.socials.twitter_username) { - formData.append("socials[twitter_username]", form.data.socials.twitter_username); - } - if (form.data.socials.discord_username) { - formData.append("socials[discord_username]", form.data.socials.discord_username); - } + formData.append("socials[github_username]", form.data.socials.github_username); + formData.append("socials[telegram_username]", form.data.socials.telegram_username); + formData.append("socials[twitter_username]", form.data.socials.twitter_username); + formData.append("socials[discord_username]", form.data.socials.discord_username); const { data: { res }, @@ -434,17 +426,18 @@ disabled={$submitting || !isSubmittable || isError} {...props} > - Update profile {isSubmittable} + Update profile {/snippet} - - Update Profile Confirmation - Confirm changes to your profile here. - -
+
+ + Update Profile Confirmation + Confirm changes to your profile here. + + {#snippet children({ props })} @@ -463,10 +456,11 @@ {/snippet} -
- - - + + + + + -- Muhammad Rizki