From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1752626647; bh=HTdU1t9/CymEpoi9JHQzO+CBlEaFcU1C4gGXbC74CZU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version: Content-Transfer-Encoding:Message-ID:Date:From:Reply-To:Subject:To: Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To: Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding; b=hcHClAxf9PnRM3Ot/fIHvVgsKI3UyfAbZ4V9pZQhWRkEQIJT0V0+aWqiXmgLd+sVr SY3/J0pIVZ1X+24t2gNIkDFbnIpU+V+uedsZ1UzeM5X4ELHXRi+HeV5Wm0h2TiCBol 8YrtePhXrclnQkVjyNo0UIYklIvmiAZOQZH1Ww7Gb658L1CDUxo9Ap7xJjCAVUlnkV O0uLlb/D70hPxwXh+P/iQqLXEppL1s/L9V306qv8FVQYSLmgKV05LtvBMBw8umtENx K6rHFurz7A8Pz7QD+93pA+No+DgDDe8VpVE8rQRcHL8+7HgXzCWlh9iaLnel48ode1 OXSvZNIDGkUfg== Received: from localhost.localdomain (unknown [68.183.184.174]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 082752109A7B; Wed, 16 Jul 2025 00:44:05 +0000 (UTC) From: Alviro Iskandar Setiawan To: Jens Axboe Cc: Alviro Iskandar Setiawan , Ammar Faizi , GNU/Weeb Mailing List , Linux Kernel Mailing List , io-uring Mailing List Subject: [PATCH liburing v2 0/3] Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build error Date: Wed, 16 Jul 2025 07:43:59 +0700 Message-Id: <20250716004402.3902648-1-alviro.iskandar@gnuweeb.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Hello, This is the v2 revision of the patch series to address the Android build error related to `memfd_create()`. The series consists of three patches: 1) Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build error. Partially reverts commit: 732bf609b670 ("test/io_uring_register: kill old memfd test") to bring back `CONFIG_HAVE_MEMFD_CREATE` to resolve Android build failures caused by: 93d3a7a70b4a ("examples/zcrx: udmabuf backed areas") It added a call to `memfd_create()`, which is unavailable on some Android toolchains, leading to the following build error: ``` zcrx.c:111:10: error: call to undeclared function 'memfd_create'; ISO C99 and \ later do not support implicit function declarations \ [-Wimplicit-function-declaration] 111 | memfd = memfd_create("udmabuf-test", MFD_ALLOW_SEALING); | ^ ``` This reversion is a preparation patch for a proper fix by ensuring `memfd_create()` usage is guarded and portable. It's only a partial revert because the test itself is not restored. 2) Move `memfd_create()` to helpers.c, make it accessible for all tests. Previously, the static definition of `memfd_create()` was limited to io_uring_register.c. Now, promote it to a shared location accessible to all test cases, ensuring that future tests using `memfd_create()` do not trigger build failures on Android targets where the syscall is undefined in the standard headers. It improves portability and prevents regressions across test builds. 3) Also, add `memfd_create()` helper in the examples directory. Changelog: v1 -> v2: - Omit the old memfd test because it's not needed anymore (Jens Axboe) Link: https://lore.kernel.org/io-uring/4bc75566-9cb5-42ec-a6b7-16e04062e0c6@kernel.dk Signed-off-by: Ammar Faizi Signed-off-by: Alviro Iskandar Setiawan --- Alviro Iskandar Setiawan (3): Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build errors test: Move `memfd_create()` to helpers.c, make it accessible for all tests examples: Add `memfd_create()` helper configure | 19 +++++++++++++++++++ examples/helpers.c | 8 ++++++++ examples/helpers.h | 5 +++++ test/helpers.c | 8 ++++++++ test/helpers.h | 5 +++++ 5 files changed, 45 insertions(+) base-commit: 0272bfa96f02cc47c024ec510a764ef7e37b76bf -- Alviro Iskandar Setiawan