public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Ahmad Gani <reyuki@gnuweeb.org>
To: ammarfaizi2@gnuweeb.org
Cc: gwml@vger.gnuweeb.org, reyuki@gnuweeb.org
Subject: [PATCH gwproxy v2 0/3] Minor changes and fixes
Date: Tue, 29 Jul 2025 10:47:16 +0700	[thread overview]
Message-ID: <20250729034719.190563-1-reyuki@gnuweeb.org> (raw)
In-Reply-To: <aIg3teXENnOKXNTh@linux.gnuweeb.org>

On Tue, 29 Jul 2025 09:53:41 +0700, Ammar Faizi wrote:
>>   io_uring: Add liburing to the code base
> 
> This one feels too big. Let's not bring liburing tests and liburing
> manpages.

As discussed in the voice chat, let's use git submodule instead.

This is v2 revision of patches that contain the following changes:
- add liburing to the code base
- add macro guard
- fix undeclared GWP_CONN_FLAG_IS_CANCEL macro

My Linux distro didn't have a static version of the liburing library.
Let's just embed the liburing source code directly into the code base.

VS Code's C/C++ linter was complaining about an undefined struct member. 
Adding a macro guard resolved the warning, although I later discovered 
that configuring the defines array in c_cpp_properties.json also fixes 
the issue, but it's still nice to have macro guard as a safe fallback.

And I noticed that declaration of GWP_CONN_FLAG_IS_CANCEL is missing, and
have now declared it.

## Changelog
v1 -> v2:
 - Using git submodule instead of pulling the code base directly.

Signed-off-by: Ahmad Gani <reyuki@gnuweeb.org>
---

Ahmad Gani (3):
  io_uring: Add liburing to the code base
  io_uring: Add macro guard
  io_uring: Rename GWP_CONN_FLAG_IS_SHUTDOWN to GWP_CONN_FLAG_IS_CANCEL

 .gitmodules               |  4 ++++
 Makefile                  | 10 ++++++++--
 src/gwproxy/ev/io_uring.c | 13 +++++++++----
 src/gwproxy/gwproxy.h     |  2 +-
 src/liburing              |  1 +
 5 files changed, 23 insertions(+), 7 deletions(-)
 create mode 100644 .gitmodules
 create mode 160000 src/liburing


base-commit: 06fa2ea2ba4acee27d03b7f467012b403df1f48c
-- 
Ahmad Gani


  parent reply	other threads:[~2025-07-29  3:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  2:48 [PATCH gwproxy v1 0/3] Minor changes and fixes Ahmad Gani
2025-07-29  2:48 ` [PATCH gwproxy v1 2/3] io_uring: Add macro guard Ahmad Gani
2025-07-29  2:48 ` [PATCH gwproxy v1 3/3] io_uring: Rename GWP_CONN_FLAG_IS_SHUTDOWN to GWP_CONN_FLAG_IS_CANCEL Ahmad Gani
2025-07-29  2:53 ` [PATCH gwproxy v1 0/3] Minor changes and fixes Ammar Faizi
2025-07-29  3:08   ` [PATCH gwproxy v2] io_uring: Reduce liburing code base Ahmad Gani
2025-07-29  3:47   ` Ahmad Gani [this message]
2025-07-29  3:47     ` [PATCH gwproxy v2 1/3] io_uring: Add liburing to the " Ahmad Gani
2025-07-29 15:06       ` Ammar Faizi
2025-07-29  3:47     ` [PATCH gwproxy v2 2/3] io_uring: Add macro guard Ahmad Gani
2025-07-29  3:47     ` [PATCH gwproxy v2 3/3] io_uring: Rename GWP_CONN_FLAG_IS_SHUTDOWN to GWP_CONN_FLAG_IS_CANCEL Ahmad Gani
2025-07-29  3:50     ` [PATCH gwproxy v2 0/3] Minor changes and fixes Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729034719.190563-1-reyuki@gnuweeb.org \
    --to=reyuki@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox