From: Ahmad Gani <reyuki@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Ahmad Gani <reyuki@gnuweeb.org>,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: [PATCH gwproxy v2 2/3] dnslookup: Allow only port string number
Date: Fri, 1 Aug 2025 08:54:23 +0700 [thread overview]
Message-ID: <20250801015427.439511-3-reyuki@gnuweeb.org> (raw)
In-Reply-To: <20250801015427.439511-1-reyuki@gnuweeb.org>
Instead of adding additional work for parsing well-known services like
http, https, etc... (port in socks5 field is a number anyway).
Signed-off-by: Ahmad Gani <reyuki@gnuweeb.org>
---
man/gwp_dns_queue.3 | 2 +-
src/gwproxy/dns.h | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/man/gwp_dns_queue.3 b/man/gwp_dns_queue.3
index dcd06746bbcc..f57807517df5 100644
--- a/man/gwp_dns_queue.3
+++ b/man/gwp_dns_queue.3
@@ -77,7 +77,7 @@ contains:
The hostname being resolved.
.TP
.B char *service
-The service name or port number (e.g., "http", "443").
+The port number in ascii format.
.TP
.B _Atomic(int) refcnt
Atomic reference count for the entry.
diff --git a/src/gwproxy/dns.h b/src/gwproxy/dns.h
index 290325d4f989..3bd437207d99 100644
--- a/src/gwproxy/dns.h
+++ b/src/gwproxy/dns.h
@@ -71,8 +71,7 @@ void gwp_dns_ctx_free(struct gwp_dns_ctx *ctx);
*
* @param ctx Pointer to the DNS context.
* @param name Name to resolve.
- * @param service Service to resolve (e.g., "http", "https", or port
- * number).
+ * @param service Service to resolve in port number ascii format.
* @return Pointer to a gwp_dns_entry on success, NULL on failure.
*/
struct gwp_dns_entry *gwp_dns_queue(struct gwp_dns_ctx *ctx,
--
Ahmad Gani
next prev parent reply other threads:[~2025-08-01 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 1:54 [PATCH gwproxy v2 0/3] Initial work for DNS lookup implementation Ahmad Gani
2025-08-01 1:54 ` [PATCH gwproxy v2 1/3] dnslookup: split common functionality and struct into net.c Ahmad Gani
2025-08-01 23:43 ` Alviro Iskandar Setiawan
2025-08-01 23:45 ` Alviro Iskandar Setiawan
2025-08-02 1:08 ` reyuki
2025-08-02 1:34 ` Alviro Iskandar Setiawan
2025-08-01 1:54 ` Ahmad Gani [this message]
2025-08-01 1:54 ` [PATCH gwproxy v2 3/3] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function Ahmad Gani
2025-08-02 1:37 ` Alviro Iskandar Setiawan
2025-08-02 2:06 ` reyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801015427.439511-3-reyuki@gnuweeb.org \
--to=reyuki@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox