From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=bftd=2R=kernel.org=kuba@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,
	RCVD_IN_VALIDITY_SAFE,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.6
Authentication-Results: server-vie001.gnuweeb.org;
	dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Xji4qPCu;
	dkim-atps=neutral
Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000)
	id 2B13A3127C32; Tue,  5 Aug 2025 23:47:52 +0000 (UTC)
Authentication-Results: server-vie001.gnuweeb.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=kuba@kernel.org; receiver=<UNKNOWN> 
Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPS id 364AE3127C26
	for <gwml@vger.gnuweeb.org>; Tue,  5 Aug 2025 23:47:51 +0000 (UTC)
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
	by sea.source.kernel.org (Postfix) with ESMTP id 832EB43669;
	Tue,  5 Aug 2025 23:47:49 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8B34C4CEF0;
	Tue,  5 Aug 2025 23:47:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1754437669;
	bh=T+TQB9L6nkRD5oCLbLR5cryrKU8+F1aWEUgdRNPnQw0=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=Xji4qPCu3qnlfabkVpSBksej6fDAS4kX5md1OfqcrAiLJdQnDqqZsumjw/OXZpxFz
	 RGtoGyJFbL1xwnKB4fTMEk3iPS2cocKvhkQXRoAb5PIzkz2OyEejSgeZg2lG+fhgVC
	 GR/5gkdcPjkEUESPItt0CBA+GkO2uXi/oHK/kpLR8lVvPDtU3BY1LRT8J/M5tgyscN
	 Lt34wXvZJ9zr0gtmdIVye5BtWnmqv6k6Fsv1vtpCUxAkdpYUOBYIhgGtPai6JlIYqp
	 bU3VjiypbFoDw2FgOuX31rb1MehFi+iAjqno/GHnqCKzEUGDQdXWfOOw6k83U5DMwC
	 IYM5zyaXSgNTA==
Date: Tue, 5 Aug 2025 16:47:47 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>, Ammar Faizi
 <ammarfaizi2@gnuweeb.org>
Cc: Simon Horman <horms@kernel.org>, Oliver Neukum <oneukum@suse.com>,
 Andrew Lunn <andrew+netdev@lunn.ch>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linux
 Netdev Mailing List <netdev@vger.kernel.org>, Linux USB Mailing List
 <linux-usb@vger.kernel.org>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Armando Budianto <sprite@gnuweeb.org>,
 gwml@vger.gnuweeb.org, stable@vger.kernel.org, John Ernberg
 <john.ernberg@actia.se>
Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on()
 call placement
Message-ID: <20250805164747.40e63f6d@kernel.org>
In-Reply-To: <CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com>
References: <20250801190310.58443-1-ammarfaizi2@gnuweeb.org>
	<20250804100050.GQ8494@horms.kernel.org>
	<20250805202848.GC61519@horms.kernel.org>
	<CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On Wed, 6 Aug 2025 01:40:37 +0300 Linus Torvalds wrote:
> So my gut feel is that the
> 
>                 if (test_and_clear_bit(EVENT_LINK_CARRIER_ON, &dev->flags))
>                         netif_carrier_on(dev->net);
> 
> should actually be done outside that if-statement entirely, because it
> literally ends up changing the thing that if-statement is testing.

Right. I think it should be before the if (!netif_carrier_ok(dev->net))

Ammar, could you retest and repost that, since we haven't heard from
John?