From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=uMMUAJZA; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 57A693127BE9; Wed, 6 Aug 2025 19:54:35 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id 92B153127BE5 for ; Wed, 6 Aug 2025 19:54:34 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 361435C0C42; Wed, 6 Aug 2025 19:54:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC8DEC4CEE7; Wed, 6 Aug 2025 19:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754510072; bh=/cOp30dms8uItY/3xX0vKGu+W81HNkXMglBIQQK17j4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uMMUAJZADmwrEA56beYBmoyUXMpDChhSxqhSlFM6twGj4izMgh0FzfADAXb/EejWj ucE7JXNZHAEeguZYuQuYXc14NuDUZGVJv0Wq/jWsjdkmOPLuWhxIN5shWv4nV1gpEX g5pQdZUM5ir+geRLPdGXUOhye02ZuWwvzopO2onaT7EmGegHe6mLZ1TfYy3nj/zL1h mn5G6oE84t9YjHh92Fao+E/lvpaSaXqZmxXqvn9m9PLCvAw1Y4YQxv14syfwhT1bMu BaCemHORXhwMK54PQh42yZt3hjhRGfSOVFLwahvUg0YryJEpprCsh7YerrEwelZ84q g1/O48Nyqh/7Q== Date: Wed, 6 Aug 2025 20:54:27 +0100 From: Simon Horman To: Ammar Faizi Cc: Oliver Neukum , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Linus Torvalds , Paolo Abeni , John Ernberg , Greg Kroah-Hartman , Linux Netdev Mailing List , Linux USB Mailing List , Linux Kernel Mailing List , Armando Budianto , gwml@vger.gnuweeb.org, stable@vger.kernel.org Subject: Re: [PATCH net v3] net: usbnet: Fix the wrong netif_carrier_on() call Message-ID: <20250806195427.GH61519@horms.kernel.org> References: <20250806003105.15172-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250806003105.15172-1-ammarfaizi2@gnuweeb.org> List-Id: On Wed, Aug 06, 2025 at 07:31:05AM +0700, Ammar Faizi wrote: > The commit referenced in the Fixes tag causes usbnet to malfunction > (identified via git bisect). Post-commit, my external RJ45 LAN cable > fails to connect. Linus also reported the same issue after pulling that > commit. > > The code has a logic error: netif_carrier_on() is only called when the > link is already on. Fix this by moving the netif_carrier_on() call > outside the if-statement entirely. This ensures it is always called > when EVENT_LINK_CARRIER_ON is set and properly clears it regardless > of the link state. > > Cc: stable@vger.kernel.org > Cc: Armando Budianto > Reviewed-by: Simon Horman > Suggested-by: Linus Torvalds > Link: https://lore.kernel.org/all/CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com > Closes: https://lore.kernel.org/netdev/CAHk-=wjKh8X4PT_mU1kD4GQrbjivMfPn-_hXa6han_BTDcXddw@mail.gmail.com > Closes: https://lore.kernel.org/netdev/0752dee6-43d6-4e1f-81d2-4248142cccd2@gnuweeb.org > Fixes: 0d9cfc9b8cb1 ("net: usbnet: Avoid potential RCU stall on LINK_CHANGE event") > Signed-off-by: Ammar Faizi FTR, this patch was applied directly by Linus: - net: usbnet: Fix the wrong netif_carrier_on() call https://git.kernel.org/torvalds/c/8466d393700f