From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1755405474;
	bh=CBoIFHIB46aBNo3s6S8Hep9fK7KDpBui+ggb/S87eRE=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-ID:Date:
	 From:Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=OIw2WWInMFeq8IhZ5W+wYaU2LJn33fkT/jOYBmQZ+Tl1sYvyErFtc7hGuT7Bk5XQ+
	 pvDz75bQ1LhDWu8rVBAPNBpoVkTIMAPuUzk/IYm9BuPbQKNnCt54BTN5FVgB5nlX4g
	 v9ykvRFTnD67eeodor27399YfkVTw0Vpsx3ONKeu28l4hu1cQjdgcj74ejYMpUll92
	 mXJawpMiKFPgKJEdAfvdNS8JWOPyRFzPE/ubSRjiMcZMAkdx5NIaZl9LiAqGG50p6L
	 P33kL/Bo9Nncxf18McaHO8IlCiXoLDEbdkAFbSk4c18e4W4MDcpx/xjJQ1otb9y4mJ
	 3i+N/ubv8f35g==
Received: from linux.gnuweeb.org (unknown [182.253.126.185])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 4387D3127E7E;
	Sun, 17 Aug 2025 04:37:53 +0000 (UTC)
Date: Sun, 17 Aug 2025 11:37:50 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency
Message-ID: <20250817043750.GA545393-ammarfaizi2@gnuweeb.org>
References: <20250817031621.81090-1-reyuki@gnuweeb.org>
 <CAOG64qOiHK8K18jEzV6vgoWt4KT1U7iLczNB-D_=dCdiJUcmoQ@mail.gmail.com>
 <CAADvAgo5pAnUhKHWq-DN2dJ0SyKm5i3E9_sw+3wBN_F3GY0nEw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAADvAgo5pAnUhKHWq-DN2dJ0SyKm5i3E9_sw+3wBN_F3GY0nEw@mail.gmail.com>
X-Gw-Outgoing-Server-Hash: 01afd303c8b96d0c1d5e80aa96a4ee40ec69888f786fa24107c0862c0644af79
X-Gw-Message-ID: a0f7ef964c668c0c70a3907b43f1e184d45c3f5b7dcb54767abfeeaf8c42bf93
X-Gw-PM-Hash: 8744bebdc3fa30688635d7fadea1af5b6effdeee37ec129adebbfe7c3540e7fa
List-Id: <gwml.vger.gnuweeb.org>

On Sun, Aug 17, 2025 at 11:34:39AM +0700, Ahmad Gani wrote:
> Ah, you're right—I forgot to close the fd when gwp_alloc_conn_pair() fails.
> 
> I'll add a close(fd) in that path and send a v2 PATCH (and I'll use v1
> instead of v0 for the subject next time).

Don't use close(), use __sys_close().

-- 
Ammar Faizi