From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v2] epoll: Improve log readability and efficiency
Date: Sun, 17 Aug 2025 12:12:47 +0700 [thread overview]
Message-ID: <20250817051247.GB553171-ammarfaizi2@gnuweeb.org> (raw)
In-Reply-To: <20250817050551.92428-1-reyuki@gnuweeb.org>
On Sun, Aug 17, 2025 at 12:05:23PM +0700, Ahmad Gani wrote:
> I noticed from the info log that the connection is reported as closed
> twice, even though I only tested with a single curl. After investigating,
> I realized it's not an error, just a misleading log message.
>
> This change fixes the confusing log and also improves efficiency:
> by moving the accept4 syscall to the top of __handle_ev_accept, we can
> eliminate an unnecessary allocation.
>
> Signed-off-by: Ahmad Gani <reyuki@gnuweeb.org>
> ---
> src/gwproxy/ev/epoll.c | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
When sending a revision without a cover letter, add a changelog after
'---' mark explaining why the revision is needed.
Allow the readers to know the reason quickly without digging through
mailing list history.
Something like this:
https://lore.kernel.org/lkml/20250806003105.15172-1-ammarfaizi2@gnuweeb.org/T/
--
Ammar Faizi
next prev parent reply other threads:[~2025-08-17 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 5:05 [PATCH gwproxy v2] epoll: Improve log readability and efficiency Ahmad Gani
2025-08-17 5:12 ` Ammar Faizi [this message]
2025-08-17 5:13 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250817051247.GB553171-ammarfaizi2@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox