From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1755407571; bh=iOj/K5oTmceO8yZnx0aQOSgsRxd7Jw1Dm2EHUooWkAo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To: Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To: Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding; b=CAZN90zyVoD4DWlvV+IBpqM5CBl9zU/jYbBo1piwG4qMrPej1+ftwYf+fGl6qRcBs LlXbZ6YDgpWQIw5ldLxiiEiMCRVs7zmp8IS/7AfMAVz7gN9iL5ovmKXlhOTa713O5W xRVPJNAeim7Ndr4A+tE0gnGmhInctwkFrTXjMWBZXHq9gNb9J0XCujgmxsKvsA1Txh BW227DMpv/YaWTo03d0Pdwm+Zc/B6LmugyVfuKORccRzVDTbg8DpVO8MBl8B7fWjAf VpMOB7kqjG82NaIPA0P/v+5LqS9ekxdLxDkFIZ7WXBpAtSX1rU9RkDqDXt+k4r7U0h +hXuUwj58S8fw== Received: from linux.gnuweeb.org (unknown [182.253.126.185]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 048263127EA2; Sun, 17 Aug 2025 05:12:50 +0000 (UTC) Date: Sun, 17 Aug 2025 12:12:47 +0700 From: Ammar Faizi To: Ahmad Gani Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List Subject: Re: [PATCH gwproxy v2] epoll: Improve log readability and efficiency Message-ID: <20250817051247.GB553171-ammarfaizi2@gnuweeb.org> References: <20250817050551.92428-1-reyuki@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250817050551.92428-1-reyuki@gnuweeb.org> X-Gw-Outgoing-Server-Hash: 01afd303c8b96d0c1d5e80aa96a4ee40ec69888f786fa24107c0862c0644af79 X-Gw-Message-ID: 5c46269fc9dabb2947703f7097f7a38e123031c27d6694806b941fc4ad27a79b X-Gw-PM-Hash: 2a6e87df643846cc901fdd082eda0ab9ca110ca6f1b7f25529dcc2c8bec076e2 List-Id: On Sun, Aug 17, 2025 at 12:05:23PM +0700, Ahmad Gani wrote: > I noticed from the info log that the connection is reported as closed > twice, even though I only tested with a single curl. After investigating, > I realized it's not an error, just a misleading log message. > > This change fixes the confusing log and also improves efficiency: > by moving the accept4 syscall to the top of __handle_ev_accept, we can > eliminate an unnecessary allocation. > > Signed-off-by: Ahmad Gani > --- > src/gwproxy/ev/epoll.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) When sending a revision without a cover letter, add a changelog after '---' mark explaining why the revision is needed. Allow the readers to know the reason quickly without digging through mailing list history. Something like this: https://lore.kernel.org/lkml/20250806003105.15172-1-ammarfaizi2@gnuweeb.org/T/ -- Ammar Faizi