From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 096393127FA2; Thu, 21 Aug 2025 00:12:39 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=none (p=none dis=none) header.from=goodmis.org Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=216.40.44.14; helo=relay.hostedemail.com; envelope-from=rostedt@goodmis.org; receiver= Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id C68CD3127F97 for ; Thu, 21 Aug 2025 00:12:36 +0000 (UTC) Received: from omf07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8F56B116AE3; Thu, 21 Aug 2025 00:12:35 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf07.hostedemail.com (Postfix) with ESMTPA id D563620038; Thu, 21 Aug 2025 00:12:33 +0000 (UTC) Date: Wed, 20 Aug 2025 20:12:36 -0400 From: Steven Rostedt To: Ammar Faizi Cc: Linux Trace Devel Mailing List , GNU/Weeb Mailing List , Alviro Iskandar Setiawan Subject: Re: [PATCH 0/2] ccli: Two small fixes for ccli Message-ID: <20250820201236.3f685799@gandalf.local.home> In-Reply-To: <20250820211434.1857859-1-ammarfaizi2@gnuweeb.org> References: <20250820211434.1857859-1-ammarfaizi2@gnuweeb.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: i4utt1c4uk9rcogafp1qp1otcdtrhr1q X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: D563620038 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19r4VF5czKCX5MVOjkWer+p/OiPS8wDJhA= X-HE-Tag: 1755735153-626963 X-HE-Meta: U2FsdGVkX192bbgRHhQLPGtmvZ4GuDa/B8VVp1V/a9H7eX78f5zAiZHPgjnilu7X+48uHCCQ2RbWHNa62nNk7+GOPSKjP7E/25TWlV2FOJYvg7WjH98ROSs5R2s0Yan7f/RKVf4gpFcpzuz6PzQSqDc+Rygi2D8YMdk4WELVLgAOxxRU8/2j+ifCYKxu4QIVPGHD631KfMfiAfb16XGLrbVPMeTvScyqLzkysgrsYWh35JcdX20fYzdk6/+lZ3Zk1EFiVXqWYBmnb6INXo2Gad1WYGPd+yV5z7WMNl9cfro5DRjvMFuBdeVa2xkupc+OW/+TCKNDK8ZTeNV7e/zuyiUdodAIgreLd8ZtkhsaSn4driXChX9gt8G9hrsh2UbW List-Id: On Thu, 21 Aug 2025 04:14:32 +0700 Ammar Faizi wrote: > Hi Steve, Hi Ammar! > > Alviro and I found two small issues in the ccli code. There's a famous Linux kernel developer named Al Viro, and when I saw the name Alviro, I was confused and was wondering why Al was working with you. But then I saw the Cc list ;-) > > The first one is a warning about uninitialized variable in the cache > code. The second one is an optimization issue found when clang warns > about unused return value of strlen() calls. > > Fix them. > > Ammar Faizi (2): > ccli: cache: Fix -Wuninitialized warning > ccli: commands: Fix optimized `strlen()` calls Thanks for the updates! FYI, I'm relicensing libccli under MIT from LGPL. Are you OK with that? Cheers, -- Steve > > src/cache.c | 3 +-- > src/ccli-local.h | 1 + > src/commands.c | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > > base-commit: 418ad6a341a5ab6c21be666565d62a878aa3bd18