From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1755724486; bh=TiOe19I1L2jODrouKdVdjc4o+RcMbLMXA4NU8ZkDZgM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=PUoA7f0F5KEp3ocd/P4RrbiwJ0w41surmZNuLM1ydRZ48fQDOZWSuxGsCifjOCBva aOrehZbwgNZD4jud/prqRMUV3jMiA+E+MR9mC2ADuP8Tg4oxoHlW4oJbjvl29k2vLt gKtBKrZO81k8Z0NbmWykEURifwX5eAqTDM7hI/+urqw6i3sJgOcR2qJe7K/k+1rQRg gaIpZEWiHINlDGyMv1WIg++Vxnk8V8yZOjTLmNWbIOA9aTBaEkLql4N5F5YlhfnB79 R9Qo4iCDGPfVIASR5naYZL0zQAMIcivL7VUCYG0C0LXhWpfgauMl9Sy5vXalMBHaBT lB6+haseqgFcQ== Received: from integral2.. (unknown [103.216.223.55]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id ABF383127F83; Wed, 20 Aug 2025 21:14:44 +0000 (UTC) From: Ammar Faizi To: Steven Rostedt Cc: Ammar Faizi , Linux Trace Devel Mailing List , GNU/Weeb Mailing List , Alviro Iskandar Setiawan Subject: [PATCH 1/2] ccli: cache: Fix -Wuninitialized warning Date: Thu, 21 Aug 2025 04:14:33 +0700 Message-Id: <20250820211434.1857859-2-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250820211434.1857859-1-ammarfaizi2@gnuweeb.org> References: <20250820211434.1857859-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: The idx variable is uninitialized and incremented. Clang warns it: cache.c:214:28: warning: variable 'idx' is uninitialized when used here [-Wuninitialized] 214 | for (i = 0; i < cnt; i++, idx++) { | ^~~ cache.c:184:9: note: initialize the variable 'idx' to silence this warning 184 | int idx; | ^ | = 0 Remove the idx variable entierly, it's not used. Co-authored-by: Alviro Iskandar Setiawan Signed-off-by: Alviro Iskandar Setiawan Signed-off-by: Ammar Faizi --- src/cache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cache.c b/src/cache.c index 010ddbd1e722..97a24066bf69 100644 --- a/src/cache.c +++ b/src/cache.c @@ -181,7 +181,6 @@ __hidden int cache_save_fd(struct ccli *ccli, const char *start_tag, char *str; char buf[64]; int ret; - int idx; int i; if (!ccli || !tag || !start_tag || !callback || fd < 0) { @@ -211,7 +210,7 @@ __hidden int cache_save_fd(struct ccli *ccli, const char *start_tag, if (ret < strlen(buf)) return -1; - for (i = 0; i < cnt; i++, idx++) { + for (i = 0; i < cnt; i++) { if (callback(ccli, fd, i, cnt, data) < 0) break; } -- Ammar Faizi