Re: [PATCH gwproxy v5 2/2] dnsparser: Add dns parser code

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On Sat, Aug 23, 2025 at 08:07:08AM +0700, Ahmad Gani wrote:
> I think it should be fine to have old DNS code removed if the raw DNS
> resolver feature is only applied when it's completed and tested.

I will ask for your feature to be experimental because your DNS feature
is not super simple. It may have undiscovered hidden bugs even if we
have extensively tested it. The same thing with the io_uring support.

And note that, getaddrinfo() is not as simple as resolving DNS queries
via UDP port 53. It does more than that. For example, it reads
/etc/hosts, /etc/resolv.conf, /etc/gai.conf and many more files.

If we missed very important details and the old resolver is already
removed, it will be a pain in the ass to 'git revert' all your work.

So please, keep the old feature intact for the time being. Develop a
new DNS resolver without bothering the old DNS feature. It's not that
simple to replace this monster.

And the good thing is that, making it an experimental feature allows
specific environments to use the feature in a stable release, but
keeping the old stable feature usable for those who are not willing to
get involved in testing and reporting bugs.

JFYI, I have started using the epoll version in a real production. And
that one still uses the epoll version because I am more confident with
my epoll version than io_uring version.

Next time, when I am confident enough with your DNS feature, I will
consider making your DNS resolver the primary one and probably kill the
old DNS resolver.

We also have a lot of features like that in the Linux kernel, for
example:

  - CONFIG_BTRFS_EXPERIMENTAL
  - CONFIG_IEEE802154_NL802154_EXPERIMENTAL
  - CONFIG_LTO (yes, LTO in the kernel is marked as experimental)
  - CONFIG_AUTOFDO_CLANG
  - any many more...

Those are unstable features, but can be configured to run on stable
kernel. I want to follow that tradition when it comes to stability of a
new feature.

> You can still keep the old DNS feature in the master branch that is meant
> to be stable (?)

I don't consider the master branch to be stable. But a tag is.
Currently we HAVE NO TAGS in gwproxy. Soon, I'll make a release.

-- 
Ammar Faizi