From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1756391797; bh=QjqV5+JAy+Q+1SpT5IVS8MsbuLQqW+T2/bosFb+db94=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=m8j1HoNBNLRWflvevNkM0gCXh1UKA8vOJlAlCnAXC4xncfK/ESA+ViShl0+zF8ScW I9lMRaDClA1EcN7+oHlCL1ZJ+V6kkFQ3z/teZmlhDTBNxYVluYf6oS7sDn1CWf/GPG IOWhnjj8tMVvL2ZHlA4zAkRoaGsBnNBMBnlkJRLH5GvBR8yjZmfJ2NR3/9Tit7KlfA TdGinpD5Ump8an2iRn+oWf9qlFOfsRUO5qNuzlLVK3mEiWqTWcDXqGwt5MWK/kYuo4 KavR3mA90GjLlZ+FB8uYMoioXngWH2Vm00t2FwwTOMk72KHGY/i7UP9+s9Qk7khPRY Prqjlx/XteDjg== Received: from zero (unknown [182.253.228.107]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 97B9B3127F74; Thu, 28 Aug 2025 14:36:28 +0000 (UTC) From: Ahmad Gani To: Ammar Faizi Cc: Ahmad Gani , Alviro Iskandar Setiawan , GNU/Weeb Mailing List Subject: [PATCH gwproxy v6 02/11] gwproxy: Fix socks5 failure on debug mode Date: Thu, 28 Aug 2025 21:34:24 +0700 Message-ID: <20250828143444.540247-3-reyuki@gnuweeb.org> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250828143444.540247-1-reyuki@gnuweeb.org> References: <20250828143444.540247-1-reyuki@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Why use assert when the caller already use if statement for the same value? this assert cause socks5 to always failed on runtime when debug mode is enabled Fixes: 9c5669f11ec6 ("gwproxy: Unify HTTP and SOCKS5 common paths") Signed-off-by: Ahmad Gani --- src/gwproxy/gwproxy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gwproxy/gwproxy.c b/src/gwproxy/gwproxy.c index ac2bbc515c4e..7a90609dd5f1 100644 --- a/src/gwproxy/gwproxy.c +++ b/src/gwproxy/gwproxy.c @@ -1246,7 +1246,6 @@ int gwp_socks5_prepare_target_addr(struct gwp_wrk *w, struct gwp_conn_pair *gcp) struct gwp_socks5_addr *dst; assert(sc); - assert(sc->state == CONN_STATE_SOCKS5_CONNECT); dst = &sc->dst_addr; memset(ta, 0, sizeof(*ta)); -- Ahmad Gani