Re: [PATCH gwproxy v6 00/11] Initial work on integration of DNS parser lib in gwproxy

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On Thu, Aug 28, 2025 at 09:34:22PM +0700, Ahmad Gani wrote:
> Ahmad Gani (11):
>   gwproxy: Fix syntax error inside assertion
>   gwproxy: Fix socks5 failure on debug mode
>   dnsparser: Add dns parser code
>   dnsparser: remove unused constant
>   dnsparser: Ignore CNAME if any
>   dns: Remove code block related to the usage of glibc's getaddrinfo_a
>     function
>   dns: refactor dns.c to integrate the dns parser
>   dns: revert removed DNS code and disable raw DNS by default
>   test: revert DNS test-case
>   gwproxy: Add DNS server option
>   dns: Add fallback mechanism for raw DNS

Stop doing the same mistake again, again, and again. Don't send a patch
to fix your previous patch. I'll add unnecessary noise for the reviewers
and clutter the git history.

For example:

- You add various enums in patch #3, but you remove them in patch #4.

- You remove getaddrinfo_a() in patch #6, but you add it again in patch #8.

- You remove the DNS tests in patch #6, but your bring the tests back
  in patch #9.

There are more patterns like that. Something like that should just
be f*ck*ng squashed. No need to bomb the list and reviewers with
unnecessary additions and removals which end up doing nothing because
your addtions are fully undone by your removals and vice-versa.

You should only send fix-and-revert patches to fix upstream commits,
not to fix your local commits.

-- 
Ammar Faizi