From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS
	autolearn=ham autolearn_force=no version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1756419789;
	bh=PvHKrKGgixDQVJMziklyeH4U7aWWaI6xvxm/0XbI13g=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:In-Reply-To:Message-ID:Date:From:Reply-To:Subject:To:
	 Cc:In-Reply-To:References:Resent-Date:Resent-From:Resent-To:
	 Resent-Cc:User-Agent:Content-Type:Content-Transfer-Encoding;
	b=tzzhUHFt81bXQU9CTTaYM+Vaosak718ZKkFXTGWe5VyqnsWvj0K72YXl0DvvPOUe4
	 N+CU1DQHJ2Rx5dHah6ZpKg+xqkfZXj8apOUyizPbTtzEFAiIvZ4EvXEB1ULdHJv2vf
	 e0toOovrPoElPNRgj3UnhSP9UYnBk+rNC/818dFk5cAt6hXugxqlbTPTGuVI9KQ9wi
	 lUE2JGH5rCp7JZWeqC/q94SHHh/ZHPZHP4lAloXehRuh3HcqSCdUA/Lt+bB5grlBXD
	 VOkdLq2kRB0qDQyNbZFZIEpC6mQfvrgJ/b0QA1ko5YtLf4mfVS2YjMueRU/RD8Wvjb
	 9XyqyO9O+xwMQ==
Received: from linux.gnuweeb.org (unknown [103.216.223.55])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 998383127EDA;
	Thu, 28 Aug 2025 22:23:07 +0000 (UTC)
Date: Fri, 29 Aug 2025 05:23:03 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v6 00/11] Initial work on integration of DNS
 parser lib in gwproxy
Message-ID: <20250828222303.GA540452-ammarfaizi2@gnuweeb.org>
References: <20250828143444.540247-1-reyuki@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250828143444.540247-1-reyuki@gnuweeb.org>
X-Gw-Outgoing-Server-Hash: 01afd303c8b96d0c1d5e80aa96a4ee40ec69888f786fa24107c0862c0644af79
X-Gw-Message-ID: a38fec1428b760dc8729526556e2f92d514ef4e2f79b63dcffa91eda552d053a
X-Gw-PM-Hash: fa2c05aede50026239dcaa95966fe6faea898610c30533081465324a286a1693
List-Id: <gwml.vger.gnuweeb.org>

On Thu, Aug 28, 2025 at 09:34:22PM +0700, Ahmad Gani wrote:
> Ahmad Gani (11):
>   gwproxy: Fix syntax error inside assertion
>   gwproxy: Fix socks5 failure on debug mode
>   dnsparser: Add dns parser code
>   dnsparser: remove unused constant
>   dnsparser: Ignore CNAME if any
>   dns: Remove code block related to the usage of glibc's getaddrinfo_a
>     function
>   dns: refactor dns.c to integrate the dns parser
>   dns: revert removed DNS code and disable raw DNS by default
>   test: revert DNS test-case
>   gwproxy: Add DNS server option
>   dns: Add fallback mechanism for raw DNS

Stop doing the same mistake again, again, and again. Don't send a patch
to fix your previous patch. I'll add unnecessary noise for the reviewers
and clutter the git history.

For example:

- You add various enums in patch #3, but you remove them in patch #4.

- You remove getaddrinfo_a() in patch #6, but you add it again in patch #8.

- You remove the DNS tests in patch #6, but your bring the tests back
  in patch #9.

There are more patterns like that. Something like that should just
be f*ck*ng squashed. No need to bomb the list and reviewers with
unnecessary additions and removals which end up doing nothing because
your addtions are fully undone by your removals and vice-versa.

You should only send fix-and-revert patches to fix upstream commits,
not to fix your local commits.

-- 
Ammar Faizi