From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ahmad Gani <reyuki@gnuweeb.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v10 2/2] gwproxy: refactor code base to add experimental raw DNS backend
Date: Sat, 13 Sep 2025 00:36:07 +0700 [thread overview]
Message-ID: <20250912173607.GB3885112-ammarfaizi2@gnuweeb.org> (raw)
In-Reply-To: <CAOG64qOvjYWb-gN7SZQAbxLaMSWuSoDu1Z35+mrqUthb+uGKYw@mail.gmail.com>
On Thu, Sep 11, 2025 at 05:11:11PM +0700, Alviro Iskandar Setiawan wrote:
> Anyway, this patch is doing too many things. It's not something you
> should do in a single commit. Please split it into smaller, more
> manageable pieces.
Indeed. This patch does too many things at once.
@Ahmad Gani, each patch should only do one substantial thing. Your patch
definitely needs to be split into smaller patches. If you want to
refactor something, do it indenpendently with your feature addiation.
For example:
Patch 1: Export 'struct gwp_dns_ctx'.
Patch 2: Add DNS parser code.
Patch 3: Add stack code.
Patch 4: Refactor something blablabla...
Patch 5: Move it to that in order to blablabla...
Patch 6: Integrate raw DNS feature to epoll.
Patch 7: Integrate raw DNS feature to io_uring.
Patch 8: Add --session-map-cap option.
and so on...
This series is also a good example of splitting patches:
https://lore.kernel.org/io-uring/20240921080307.185186-1-axboe@kernel.dk/
P.S. Don't follow the example as is, adjust it with your own situation.
I don't want you arguing: "You gave me that example, so I did exactly
what you told me, even if it's not suitable for the situation in
question.".
--
Ammar Faizi
next prev parent reply other threads:[~2025-09-12 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 10:43 [PATCH gwproxy v10 0/2] Initial work on integration of DNS parser lib in gwproxy Ahmad Gani
2025-09-10 10:43 ` [PATCH gwproxy v10 1/2] dnsparser: Add dns parser code Ahmad Gani
2025-09-10 10:43 ` [PATCH gwproxy v10 2/2] gwproxy: refactor code base to add experimental raw DNS backend Ahmad Gani
2025-09-11 10:11 ` Alviro Iskandar Setiawan
2025-09-12 10:37 ` Ahmad Gani
2025-09-12 14:39 ` Alviro Iskandar Setiawan
2025-09-12 15:49 ` Ammar Faizi
2025-09-12 15:52 ` Ahmad Gani
2025-09-12 16:42 ` Alviro Iskandar Setiawan
2025-09-12 17:00 ` Alviro Iskandar Setiawan
2025-09-14 4:31 ` Ahmad Gani
2025-09-12 17:36 ` Ammar Faizi [this message]
2025-09-14 4:34 ` Ahmad Gani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250912173607.GB3885112-ammarfaizi2@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox