From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757698576; bh=NnCGI/LfBIkeeA2fE0Oi7y5UM4Wj+tTWMS3pK3hBBZQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To:X-Gw-Outgoing-Server-Hash:X-Gw-Message-ID: X-Gw-PM-Hash:Message-ID:Date:From:Reply-To:Subject:To:Cc: In-Reply-To:References:Resent-Date:Resent-From:Resent-To:Resent-Cc: User-Agent:Content-Type:Content-Transfer-Encoding; b=O/zjU7psGtBqz6FF07iq3qnlU4PfBOU+jLjcNYFkyip72wcYT0m1ZBg6hBwaZhF4n 6Gk7rGbDdfeeeFocjIMz4rGZfvkNlXUaO6Hz2VQbfAvHVzuvKq2olZgz9VG8VoIK94 jWW3RPYY5jTvyc2nMMzgjQkHSQU3Jb8xDw5duVOfoEws4X54PARb6CiqLh/qZKRYDT 607hHTyTBlufsaCFxl3dHdXXS7rqbFIO9Q3AXW84p8Unr4o5bdBySW53ehYUwVzjxz UeQfTHZ9+bm8OyAHlLvoy5TdO92SxHJcQE0TESU2MVSEqzTkeIV4Hfc1LXAcSzrygY 4EnSuIOm3IJpw== Received: from linux.gnuweeb.org (unknown [182.253.126.215]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 9D2FD31279E7; Fri, 12 Sep 2025 17:36:14 +0000 (UTC) Date: Sat, 13 Sep 2025 00:36:07 +0700 From: Ammar Faizi To: Alviro Iskandar Setiawan Cc: Ahmad Gani , GNU/Weeb Mailing List Subject: Re: [PATCH gwproxy v10 2/2] gwproxy: refactor code base to add experimental raw DNS backend Message-ID: <20250912173607.GB3885112-ammarfaizi2@gnuweeb.org> References: <20250910104326.580778-1-reyuki@gnuweeb.org> <20250910104326.580778-3-reyuki@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Gw-Outgoing-Server-Hash: 01afd303c8b96d0c1d5e80aa96a4ee40ec69888f786fa24107c0862c0644af79 X-Gw-Message-ID: f2fa31bba81b459ee5e049fa77cd5855f89431a29bcf77b5ec3a72ea176ee87e X-Gw-PM-Hash: 02dd3245fa5dea3a86252ee66f211fa4021b7a56629afcdabc1a5534636fa46e List-Id: On Thu, Sep 11, 2025 at 05:11:11PM +0700, Alviro Iskandar Setiawan wrote: > Anyway, this patch is doing too many things. It's not something you > should do in a single commit. Please split it into smaller, more > manageable pieces. Indeed. This patch does too many things at once. @Ahmad Gani, each patch should only do one substantial thing. Your patch definitely needs to be split into smaller patches. If you want to refactor something, do it indenpendently with your feature addiation. For example: Patch 1: Export 'struct gwp_dns_ctx'. Patch 2: Add DNS parser code. Patch 3: Add stack code. Patch 4: Refactor something blablabla... Patch 5: Move it to that in order to blablabla... Patch 6: Integrate raw DNS feature to epoll. Patch 7: Integrate raw DNS feature to io_uring. Patch 8: Add --session-map-cap option. and so on... This series is also a good example of splitting patches: https://lore.kernel.org/io-uring/20240921080307.185186-1-axboe@kernel.dk/ P.S. Don't follow the example as is, adjust it with your own situation. I don't want you arguing: "You gave me that example, so I did exactly what you told me, even if it's not suitable for the situation in question.". -- Ammar Faizi