public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Ahmad Gani <reyuki@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Ahmad Gani <reyuki@gnuweeb.org>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: [PATCH gwproxy v11 0/6] Initial work on integration of DNS parser lib in gwproxy
Date: Sun, 14 Sep 2025 12:09:34 +0700	[thread overview]
Message-ID: <20250914050943.184934-1-reyuki@gnuweeb.org> (raw)

Hi Chief,

This is revision v11 of the initial work on the integration of the DNS
parser lib in gwproxy.

There are 6 patches in this series:
- Use __sys_close instead of close
- Define __maybe_unused macro
- Add dns parser code
- Refactor code base to add experimental raw DNS backend
- Update Makefile and configure scripts
- Reduce #ifdef CONFIG_RAW_DNS

Please give it a test, and thanks for taking a look.

# Changelog
v1 -> v2:
- use existing convert_str_to_ssaddr instead of init_addr
- fix memory leak when init_addr (now it's replaced) failed
- modify convert_str_to_ssaddr to support default port
- bring back __cold attribute on convert_ssaddr_to_str
- don't fill a dangling pointer as Sir Alviro said
- for now it's blocking, attempt_retry label is not needed

v2 -> v3:
- remove TODO(reyuki): hints->ai_family is used to filter results
- make gw_ares_getaddrinfo asynchronous by change UDP socket to non-blocking
- move socket creation to library initialization
- make UDP socket unconnected
- restructure internal struct and program execution flow to support async
- update unit test of dns parser
- transaction id creation is delegated to caller
- fix logic bug in serialize_answ that can lead to memory error: invalid read
- rename parameter prt and split commit message
- move variable declaration in for loop according to the Sir Alviro coding-style

v3 -> v4:
- add else block in the convert_str_to_ssaddr function
- use format specifier %hu for uint16_t in printf
- update base commit to branch master from upstream remote repository

v4 -> v5:
- squash commits to eliminate changes unrelated to the commit subject
- change commit subject: use imperative form for the subject
- update base commit to branch master from upstream remote repository
- changing the email subject
- drop the c-ares style thing
- restructure dnsparser.c and dnsparser.h

v5 -> v6:
- mark this feature as experimental and disabled by default
- fix minor issues from master branch
- fix dns parser
- add dns server as gwproxy' cmdline option
- add fallback mechanism for raw dns backend

v6 -> v7:
- squash commits
- refactor gwproxy codebase (specifically, DNS system)
- add dns parser code

v7 -> v8:
- use __sys_close instead of libc's wrapper close
- add newline at EoF
- fix warning: 'af' may be used uninitialized [-Wmaybe-uninitialized]
- remove break that occured after goto statement

v8 -> v9:
- use a single UDP socket for each gwproxy worker
- expose gwp_dns_ctx members to other source files
- apply revisions from Sir Alviro's review
- apply proposals from Sir Alviro and Sir Ammar

v9 -> v10:
- fix realloc issue

v10 -> v11:
- split patchset into more managable patches
- Use __sys_close instead of close
- Define __maybe_unused macro
- Add dns parser code
- Refactor code base to add experimental raw DNS backend
- Update Makefile and configure scripts
- Reduce #ifdef CONFIG_RAW_DNS

Ahmad Gani (6):
  dns: Use __sys_close instead of close
  gwproxy: Define __maybe_unused macro
  dnsparser: Add dns parser code
  gwproxy: Refactor code base to add experimental raw DNS backend
  gwproxy: Update Makefile and configure scripts
  gwproxy: Reduce #ifdef CONFIG_RAW_DNS

 Makefile                |   2 +-
 configure               |   8 +
 src/gwproxy/common.h    |   4 +
 src/gwproxy/dns.c       | 271 +++++++++++++++----
 src/gwproxy/dns.h       |  52 +++-
 src/gwproxy/dnsparser.c | 583 ++++++++++++++++++++++++++++++++++++++++
 src/gwproxy/dnsparser.h | 192 +++++++++++++
 src/gwproxy/ev/epoll.c  | 140 +++++++++-
 src/gwproxy/gwproxy.c   | 189 ++++++++++++-
 src/gwproxy/gwproxy.h   |  84 ++++++
 10 files changed, 1455 insertions(+), 70 deletions(-)
 create mode 100644 src/gwproxy/dnsparser.c
 create mode 100644 src/gwproxy/dnsparser.h


base-commit: b1e70e468bab135a14a8faee3ea535ace9eac211
-- 
Ahmad Gani


             reply	other threads:[~2025-09-14  5:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14  5:09 Ahmad Gani [this message]
2025-09-14  5:09 ` [PATCH gwproxy v11 1/6] dns: Use __sys_close instead of close Ahmad Gani
2025-09-14  5:09 ` [PATCH gwproxy v11 2/6] gwproxy: Define __maybe_unused macro Ahmad Gani
2025-09-14  5:09 ` [PATCH gwproxy v11 3/6] dnsparser: Add dns parser code Ahmad Gani
2025-09-14  5:09 ` [PATCH gwproxy v11 4/6] gwproxy: Refactor code base to add experimental raw DNS backend Ahmad Gani
2025-09-14 12:14   ` Ammar Faizi
2025-09-14 13:54     ` Alviro Iskandar Setiawan
2025-09-14 17:46     ` Ahmad Gani
2025-09-14  5:09 ` [PATCH gwproxy v11 5/6] gwproxy: Update Makefile and configure scripts Ahmad Gani
2025-09-14 12:55   ` Ammar Faizi
2025-09-14 17:45     ` Ahmad Gani
2025-09-14  5:09 ` [PATCH gwproxy v11 6/6] gwproxy: Reduce #ifdef CONFIG_RAW_DNS Ahmad Gani
2025-09-14 12:16   ` Ammar Faizi
2025-09-14 14:26     ` Alviro Iskandar Setiawan
2025-09-14 17:45       ` Ahmad Gani
2025-09-14 17:59         ` Alviro Iskandar Setiawan
2025-09-14 18:13           ` Ahmad Gani
2025-09-15  2:21           ` Alviro Iskandar Setiawan
2025-09-14 17:44     ` Ahmad Gani
2025-09-14 19:02       ` Ammar Faizi
2025-09-15  2:50       ` Alviro Iskandar Setiawan
2025-09-14 12:51 ` (subset) [PATCH gwproxy v11 0/6] Initial work on integration of DNS parser lib in gwproxy Ammar Faizi
2025-09-14 17:22 ` Alviro Iskandar Setiawan
2025-09-14 18:07   ` Ahmad Gani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250914050943.184934-1-reyuki@gnuweeb.org \
    --to=reyuki@gnuweeb.org \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox