From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757852065; bh=M0OO1vCOvM9VBcln3ntD5TGLJfRemaBW2Yi5+DXxwDU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To:X-Gw-Outgoing-Server-Hash:X-Gw-Message-ID: X-Gw-PM-Hash:Message-ID:Date:From:Reply-To:Subject:To:Cc: In-Reply-To:References:Resent-Date:Resent-From:Resent-To:Resent-Cc: User-Agent:Content-Type:Content-Transfer-Encoding; b=YZDN3lUXD8BXKWG1guDlFhkfjjW3tyYC2ElAvdvdMqa6LygnCEw4i8RTS2UlPQVqT jb9myEZyJ2grDn/vde8Nk/tx0FViyzoWHnRUTDMIt/mHGe6Su49dRBQ+Pp3/fcqYsk QcfwzREW6KsUstJk7XSDVhbTq9ntzvQbdmuxVaWEXtLmQ9/mQJ0DFnI8RCOq2ljO6L 4h40v/Cb5Lw8ghEXASFybL8fAmk5GxHxjHhGSo9lq6cMjGwHIuOskfi01aGLiPnl1X lL/YtVJGJpy9Z38Zc3vs/uqfJFItuoh/5JRXalr/MVQuoeMLnLNW/VoXvGtp2+yWfu lBsnZ0kD+j2TQ== Received: from linux.gnuweeb.org (unknown [182.253.126.238]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 5565131279E6; Sun, 14 Sep 2025 12:14:23 +0000 (UTC) Date: Sun, 14 Sep 2025 19:14:17 +0700 From: Ammar Faizi To: Ahmad Gani Cc: Alviro Iskandar Setiawan , GNU/Weeb Mailing List Subject: Re: [PATCH gwproxy v11 4/6] gwproxy: Refactor code base to add experimental raw DNS backend Message-ID: <20250914121417.GB31788-ammarfaizi2@gnuweeb.org> References: <20250914050943.184934-1-reyuki@gnuweeb.org> <20250914050943.184934-5-reyuki@gnuweeb.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250914050943.184934-5-reyuki@gnuweeb.org> X-Gw-Outgoing-Server-Hash: 01afd303c8b96d0c1d5e80aa96a4ee40ec69888f786fa24107c0862c0644af79 X-Gw-Message-ID: 69bdbc9f940afd776081821f9fa810c6830cd39bcf9f613d97449c2948bd9b81 X-Gw-PM-Hash: 15fa1b86cfde8d1fea056597e811231aa9750ec8bc49fba31f2b60ebbd104993 List-Id: On Sun, Sep 14, 2025 at 12:09:38PM +0700, Ahmad Gani wrote: > Use fallback mechanism for raw DNS > If *_PREFER_* is used in the restyp, the raw DNS backend will attempt to > retry DNS query with different address family if it failed. > > Add new cmdline arguments: > - raw-dns: enables the experimental raw DNS feature > - dns-server: sets the default DNS server > - session-map-cap: sets the default capacity for the session_map and stack.arr arrays > > The struct gwp_dns_ctx is now exported due to the need for accessing it > outside dns.c. Let me tell you this again. Please ponder it seriously! Take a break. Use your brain to actually comprehend the meaning. Each patch should only do one substantial thing. And if **you refactor** something, **do it independently** with your feature addition. Don't mix them into a single patch. "Feature addition" **is not** a part of code refactoring. If you refactor something, there must not be a functional change. "Code refactoring" MUST NOT add a new feature. -- Ammar Faizi