From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1758237397;
	bh=+X0mBLOpr7MFQGcdAH18pZzGYjKuI8NbnpPN545F6po=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:In-Reply-To:X-Gw-Outgoing-Server-Hash:X-Gw-Message-ID:
	 X-Gw-PM-Hash:Message-ID:Date:From:Reply-To:Subject:To:Cc:
	 In-Reply-To:References:Resent-Date:Resent-From:Resent-To:Resent-Cc:
	 User-Agent:Content-Type:Content-Transfer-Encoding;
	b=D7DWq7+eD88ANR1ffixco7BiIFTFv70ecDNs07Qg6pMbrIqyGb80hfY8dc1HPC5MR
	 n71M0cENC4I5ybEWwEcn+x+E4RmBA/NjicGSc2MIQ4KIA1cjlOMQhkug3SgrvGkKl6
	 yzv9sNNGvbE/kHWpg9pKWAhXcJsMcdJ3/+bviY4kcDNwZ9dbSliJb6PNhwm1VMLHvC
	 Rr2DlBISHUA1VVN+0S6tj32ANVbIBR79a1GAy2n3OR69doH4PVV5DFPKxqjpxYC1ZK
	 6+Qocw31o4aTQW77UJpCMjz+g7MuUdrrOF1u0I0AbLw53ZC3flMwJkDMYkgSlC/Gi+
	 iHAIXKPSxFFjQ==
Received: from linux.gnuweeb.org (unknown [182.253.126.210])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 91E33312799D;
	Thu, 18 Sep 2025 23:16:36 +0000 (UTC)
Date: Fri, 19 Sep 2025 06:16:33 +0700
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ahmad Gani <reyuki@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v12 5/8] dns_resolver: Add DNS resolution
 interface APIs
Message-ID: <20250918231633.GB1128776-ammarfaizi2@gnuweeb.org>
References: <20250918184730.598305-1-alviro.iskandar@gnuweeb.org>
 <20250918184730.598305-6-alviro.iskandar@gnuweeb.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250918184730.598305-6-alviro.iskandar@gnuweeb.org>
X-Gw-Outgoing-Server-Hash: 01afd303c8b96d0c1d5e80aa96a4ee40ec69888f786fa24107c0862c0644af79
X-Gw-Message-ID: b64afcff65c65c22ec7169e5a0b5392a8ec18c5cc769b90d367d92e35f38c720
X-Gw-PM-Hash: 80794a19b718d00f3581a5f5cff20e9db484e58a1f9d25a9853e2541b6e884b5
List-Id: <gwml.vger.gnuweeb.org>

On Fri, Sep 19, 2025 at 01:47:27AM +0700, Alviro Iskandar Setiawan wrote:
> +void gwp_dns_res_drop_query(struct gwp_dns_resolver *res,
> +			    struct gwp_conn_pair *gcp, uint16_t txid)
> +{
> +	assert(gcp);
> +	assert(gcp == lookup_map(res->sess_map, txid));
> +	delete_map(res->sess_map, txid);
> +	(void)gcp;
> +}

It seems this function, gwp_dns_res_drop_query(), is not called
anywhere. Based on the function naming, I guess it's supposed to be
called from gwp_dns_res_complete_query() where you're expected to
clear an index in the map after the corresponding DNS query has been
completed?

-- 
Ammar Faizi