public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: fix a memory leak of buffer group list on exit
@ 2022-05-26 17:36 Jens Axboe
  0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2022-05-26 17:36 UTC (permalink / raw)
  To: io-uring, Pavel Begunkov

If we use a buffer group ID that is large enough to require io_uring
to allocate it, then we don't correctly free it if the cleanup is
deferred to the ring exit. The explicit removal paths are fine.

Fixes: 9cfc7e94e42b ("io_uring: get rid of hashed provided buffer groups")
Signed-off-by: Jens Axboe <[email protected]>

---

diff --git a/fs/io_uring.c b/fs/io_uring.c
index f7e1fc85d266..ccb47d87a65a 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -11065,6 +11065,7 @@ static void io_destroy_buffers(struct io_ring_ctx *ctx)
 	xa_for_each(&ctx->io_bl_xa, index, bl) {
 		xa_erase(&ctx->io_bl_xa, bl->bgid);
 		__io_remove_buffers(ctx, bl, -1U);
+		kfree(bl);
 	}
 
 	while (!list_empty(&ctx->io_buffers_pages)) {

-- 
Jens Axboe



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-05-26 17:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-26 17:36 [PATCH] io_uring: fix a memory leak of buffer group list on exit Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox