From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from [192.168.43.69] (unknown [114.10.7.234]) by gnuweeb.org (Postfix) with ESMTPSA id 95EB37E2CF; Thu, 10 Mar 2022 01:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1646877417; bh=S24z/t0QvOEntOijnJinUqvbbvEQPEekxjzJptrBJeE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UbgY3rrFyFXJ/ibKUs7htmEdqCjrbw9WZEtiv/C1zfOOIurJqnvsu3ksOzcVltmLc BpTQmvmUKMBDmH8yRtW2KnSfnvvhAt57669e3cqNigGB11tua8eE6LrnSq2nQWnN3w l0VwWFMN5wRQygja9COGAxzHPgOquxXuu2v7jvrPixz0XvIfTgDG+iXRr0uUsIFwf2 /ID4a/Fv4af7n1hMddxfx1qmKcfYtuRVUBxYMkMasRM4JHiMPKHdnUea8zpLCdhntC 70/1CxeDetnnZk9/Il0Azr18Eogxnz6zB81Ox8s455pn6BEf85HToK4FPbXJx4Chrs 8LaReuVb4ty0Q== Message-ID: <2530ff9c-4861-2295-6156-356da33f9565@gnuweeb.org> Date: Thu, 10 Mar 2022 08:56:37 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails Content-Language: en-US To: Yazen Ghannam Cc: Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Tony Luck , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, gwml@vger.gnuweeb.org, x86@kernel.org, stable@vger.kernel.org, Alviro Iskandar Setiawan , Jiri Hladky , Greg Kroah-Hartman , Alviro Iskandar Setiawan References: <20220301094608.118879-1-ammarfaizi2@gnuweeb.org> <20220301094608.118879-3-ammarfaizi2@gnuweeb.org> <4371a592-6686-c535-4daf-993dedb43cd4@gnuweeb.org> <109a10da-d1d1-c47a-2f04-31796457f6ff@gnuweeb.org> <20220303015826.4176416-1-alviro.iskandar@gnuweeb.org> <49313736-61f8-d001-0fe4-b6166c859585@gnuweeb.org> <9dfe087a-f941-1bc4-657d-7e7c198888ff@gnuweeb.org> From: Ammar Faizi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: On 3/10/22 3:55 AM, Yazen Ghannam wrote: > The commit message should use passive voice: no "I" or "we". > > Otherwise, I think the patch looks good. Fixed in the v5 revision, thanks! Link: https://lore.kernel.org/lkml/20220310015306.445359-1-ammarfaizi2@gnuweeb.org/ -- Ammar Faizi