From: Ammar Faizi <[email protected]>
To: David Laight <[email protected]>, Willy Tarreau <[email protected]>
Cc: "Paul E. McKenney" <[email protected]>,
Alviro Iskandar Setiawan <[email protected]>,
Nugraha <[email protected]>,
Linux Kernel Mailing List <[email protected]>,
GNU/Weeb Mailing List <[email protected]>,
"[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: [RFC PATCH v1 3/6] tools/nolibc: i386: Implement syscall with 6 arguments
Date: Sun, 20 Mar 2022 22:04:14 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/20/22 8:10 PM, David Laight wrote:
> From: Ammar Faizi
>> Sent: 20 March 2022 09:38
>>
>> In i386, the 6th argument of syscall goes in %ebp. However, both Clang
>> and GCC cannot use %ebp in the clobber list and in the "r" constraint
>> without using -fomit-frame-pointer. To make it always available for any
>> kind of compilation, the below workaround is implemented.
>>
>> For clang (the Assembly statement can't clobber %ebp):
>> 1) Save the %ebp value to the redzone area -4(%esp).
>
> i386 doesn't have a redzone.
> If you get a signal it will trash -4(%sp)
OK, I missed that one. Thanks for reviewing this.
>> For GCC, fortunately it has a #pragma that can force a specific function
>> to be compiled with -fomit-frame-pointer, so it can always use "r"(var)
>> where `var` is a variable bound to %ebp.
>
> How is that going to work for an inlined functon?
It works, but obviously the inline modifier here is just a hint for the
compiler, not a requirement. I just took a look at the GCC generated code.
It doesn't inline the ____do_syscall6() despite it's marked as inline.
I think this one shouldn't be marked as inline. I will remove the inline
in the next version.
> And using xchg is slow - it is always locked.
>
> One possibility might be to do:
> push arg6
> push %ebp
> mov %ebp, 4(%sp)
Did you mean `mov 4(%esp), %ebp`?
> int 0x80
> pop %ebp
> add %esp,4
I think your solution is better than the xchg approach (with the 3rd line
fixed). Will take this in for the next version.
> Although I'm not sure you really want to allocate 4k pages
> for every malloc() call.
>
> Probably better to write a mini 'libc' that uses sbrk()
> and a best fit scan of a linear free list.
^ This part is addressed by Willy's response. I will still go with mmap()
in the next version.
And yes, we do waste space for small allocations here, but we don't hit
the scale that the waste space will cause problem.
--
Ammar Faizi
next prev parent reply other threads:[~2022-03-20 15:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 9:37 [RFC PATCH v1 0/6] Add dynamic memory allocator support for nolibc Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 1/6] tools/nolibc: x86-64: Update System V ABI document link Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 2/6] tools/nolibc: Make the entry point not weak for clang Ammar Faizi
2022-03-20 19:16 ` Willy Tarreau
2022-03-21 11:38 ` Ammar Faizi
2022-03-21 17:27 ` Nick Desaulniers
2022-03-20 9:37 ` [RFC PATCH v1 3/6] tools/nolibc: i386: Implement syscall with 6 arguments Ammar Faizi
2022-03-20 10:33 ` Alviro Iskandar Setiawan
2022-03-20 10:42 ` Alviro Iskandar Setiawan
2022-03-20 15:09 ` Ammar Faizi
2022-03-20 13:10 ` David Laight
2022-03-20 14:01 ` Willy Tarreau
2022-03-20 15:04 ` Ammar Faizi [this message]
2022-03-20 18:22 ` David Laight
2022-03-20 9:37 ` [RFC PATCH v1 4/6] tools/nolibc/sys: Implement `mmap()` and `munmap()` Ammar Faizi
2022-03-20 9:37 ` [RFC PATCH v1 5/6] tools/nolibc/stdlib: Implement `malloc()`, `calloc()`, `realloc()` and `free()` Ammar Faizi
2022-03-20 15:50 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-20 16:16 ` Willy Tarreau
2022-03-20 16:36 ` Ammar Faizi
2022-03-20 16:46 ` Willy Tarreau
2022-03-20 9:37 ` [RFC PATCH v1 6/6] tools/include/string: Implement `strdup()` and `strndup()` Ammar Faizi
2022-03-20 15:55 ` Alviro Iskandar Setiawan
2022-03-20 16:10 ` Ammar Faizi
2022-03-21 7:53 ` Willy Tarreau
2022-03-21 8:16 ` Alviro Iskandar Setiawan
2022-03-21 8:51 ` Willy Tarreau
2022-03-21 11:36 ` Ammar Faizi
2022-03-21 11:43 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox