From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kiizuha@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.2] (unknown [101.128.126.198])
	by gnuweeb.org (Postfix) with ESMTPSA id 05EE2804D1;
	Mon,  7 Nov 2022 01:48:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1667785731;
	bh=grP2Nx69cUOnPgcoD06GmIQh63OW4qemciNY0oZP8Ek=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=GDW5G+Ka6GPYmB+unLIkJSc+mcrBOEKhrqSR3MYgCkWWsLIf63v0CGiNOu3Y7UeG+
	 F96/RXrgFgoMypcakpvH9iBGIqktjUITkCne/xyu1IlfRbHMQXs4S6BkbL/hVDxr40
	 2HkLfRkYtY1bopbUFnRT9xCxCUGxp+GO9oPZUH3CXIJdccvav2kvNG3NcJk4Iv12ap
	 dPdmtmGt84CmE0g2Qx+mioGwP6ZWqkP45Ds4BJiV909fyKFaFFbJPBXlb8aLIcwwEo
	 XTDIbGM8COJuD8wcibU1x4X69ch0ncqyLs73k/sjcIsI07LBzjSH09MsvW1lcG3B41
	 +cURyRfpzcaZQ==
Message-ID: <2be14772-1a83-2d5f-e351-2796246bdb21@gnuweeb.org>
Date: Mon, 7 Nov 2022 08:48:46 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v1 11/16] telegram: Implement the log message for catching
 errors
Content-Language: en-US
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221104180931.3852-1-kiizuha@gnuweeb.org>
 <20221104180931.3852-15-kiizuha@gnuweeb.org>
 <8ce63732-0cdb-e3b0-f292-5433e5b35ff1@gnuweeb.org>
 <9bce4733-0133-adf9-6291-3a932df80973@gnuweeb.org>
 <5151f6a6-f87d-1c7f-3333-26adb5223e32@gnuweeb.org>
 <6d954bf9-096f-626d-2465-43512323277f@gnuweeb.org>
 <5ab12c59-d8f3-efbe-38c9-0ff92e398741@gnuweeb.org>
 <e8fefc5c-b039-3859-eacc-622ef736f472@gnuweeb.org>
 <88d08ff0-c00f-8e32-05dc-ad7abd5ebff9@gnuweeb.org>
From: Muhammad Rizki <kiizuha@gnuweeb.org>
In-Reply-To: <88d08ff0-c00f-8e32-05dc-ad7abd5ebff9@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 07/11/2022 08.42, Ammar Faizi wrote:
> On 11/7/22 8:34 AM, Muhammad Rizki wrote:
>> You wrote v2 and v3, and the v4 is me. You wrote the v2 and v3 is from 
>> the
>> database reconnect patch.
> 
> I see, I understand what you were thinking about. Let me explain to you.
> 
> If you want to reference a commit that is already in the master branch, 
> you can
> use the SHA1 hash to mention the commit. Also, please use "Fixes" tag if 
> the
> patch fixes a problem introduced by a commit that is already in the master
> branch.
> 
> Something like this for example:
> https://github.com/torvalds/linux/commit/80ef928643c1558a0474389fcd680a5ccd6c86e6
> 

Ohh, I see now. I could just remove them instead while I just adding the 
logger attribute in that file.

>> Yes, without further a due, let me just remove them instead :)
> 
> Thanks for the clarification.
> 

Your welcome.