From: Jens Axboe <[email protected]>
To: Christoph Hellwig <[email protected]>, Vasily Averin <[email protected]>
Cc: [email protected], [email protected],
Pavel Begunkov <[email protected]>,
Steven Rostedt <[email protected]>,
Ingo Molnar <[email protected]>,
[email protected]
Subject: Re: [PATCH v2] io_uring: fix sparce warnings about __kernel_rwf_t casts
Date: Thu, 19 May 2022 06:13:36 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 5/19/22 1:03 AM, Christoph Hellwig wrote:
>> index cddf5b6fbeb4..34839f30caee 100644
>> --- a/include/trace/events/io_uring.h
>> +++ b/include/trace/events/io_uring.h
>> @@ -520,7 +520,7 @@ TRACE_EVENT(io_uring_req_failed,
>> __entry->off = sqe->off;
>> __entry->addr = sqe->addr;
>> __entry->len = sqe->len;
>> - __entry->op_flags = sqe->rw_flags;
>> + __entry->op_flags = sqe->poll32_events;
>> __entry->buf_index = sqe->buf_index;
>> __entry->personality = sqe->personality;
>> __entry->file_index = sqe->file_index;
>
> For which I did not see a warning even if it looks real to me.
> But this union with basically a lot of __u32s here looks pretty
> strange to start with to me.
Vasily, if this is still causing unnecessary sparse spews, please send a
revised one against the current branch.
The union is the per-op flags. The requests that use them have a member
in there, either one can be used for printing it obviously.
--
Jens Axboe
next prev parent reply other threads:[~2022-05-19 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[email protected]>
2022-05-18 9:20 ` [PATCH v2] io_uring: fix sparce warnings about __kernel_rwf_t casts Vasily Averin
2022-05-19 7:03 ` Christoph Hellwig
2022-05-19 12:13 ` Jens Axboe [this message]
2022-05-19 14:30 ` [PATCH v3] io_uring: fix incorrect __kernel_rwf_t cast Vasily Averin
2022-05-19 18:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox