From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <hzmi@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM,
	URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
Received: from [192.168.1.3] (unknown [36.74.43.91])
	by gnuweeb.org (Postfix) with ESMTPSA id E403A7E7C6;
	Sun,  1 May 2022 12:15:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1651407343;
	bh=VDrm2adpJiWT44jvnauMzdMo5cJ/NQUzL5bGTCgc3G0=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=eg5lPrJodfMgK7L1f1t7Xp4Wkyq6jRmp3dhUMVjMleENhPtxPHPUTlFPt3fk2Po73
	 tI/EMmz0NM8VIqIXsqLI/7ARC52x/bX0Mtk3ZUWAIuYDJs/aq8h63kHN3yal9tP6T0
	 nndL1RRhQcOGT3f3imqsCjsJOLJCTevPIfoJnjlzQMoq5cJP6fZISvP417DVjvTYpZ
	 a/nvEiZ9asym4kl+IQ/lBu+mDOUDHAYxB2YJ6+sBCkLhJg9jgjiwAzxalQeVtBxSAe
	 LXRcu83a0miC08onEgryTWmKTrLywFb+XDRBUMRBiOBNKedyhBN6B5SykF4kLlWTHh
	 CRmNeiXaSr8mw==
Message-ID: <3001b4d2-04fa-a78f-dad0-c94ded55a90b@gnuweeb.org>
Date: Sun, 1 May 2022 19:15:34 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH server-a001 v2 4/4] Create start.sh to start the docker
 container
Content-Language: en-US
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Cc: Hazmi Alfarizqi <contact@hzmi.xyz>,
 Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
References: <20220430170838.19571-1-ammarfaizi2@gnuweeb.org>
 <20220430170838.19571-5-ammarfaizi2@gnuweeb.org>
From: Hazmi Alfarizqi <hzmi@gnuweeb.org>
In-Reply-To: <20220430170838.19571-5-ammarfaizi2@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 01/05/2022 00:08, Ammar Faizi wrote:
> Create a file named start.sh. This is a script to start the container
> with prepared configuration. Only run this script on the host.
>
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

It seems that `server-a001` gonna be the image name? I would assume we 
will build the Docker image from Dockerfile directly on the host.


If not and the image will be pulled from some registry, the image name 
format would look like: [registry/]Username/Image[:tag] (Example: 
docker.io/username/image:latest).

The tag is optional, the default tag would be latest.
For the registry part, if it's docker.io (which is the default registry 
for Docker) it will be omitted on Docker, but not on Podman.


Other than that, LGTM.

Reviewed-by: Hazmi Alfarizqi <hzmi@gnuweeb.org>

-- hzmi