Re: [PATCH v1 08/13] feat(discord): Implement the report_err()

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 04/01/2023 05.20, Ammar Faizi wrote:
> On 1/3/23 7:20 PM, Muhammad Rizki wrote:
>> I already added the same custom exception, DaemonException() is
>> reusable error class for both Telegram and Discord. The location is
>> in the exceptions.py in the daemon directory.
> 
> [ Sending this again because it seems you didn't care with my next reply ]
> 
> OK, just took a look at patch #12, and you implemented it there.
> But why should we implement the broken report_err() first, then
> the fixed report_err() with DaemonException?
> 
> I think implementing the old broken exception handling design is
> not needed, just go with the DaemonException pattern we agree on.
> 

I still don't understand what's your mean, you mean this?

	atom_url = None
         try:

                 for atom_url in self.db.get_atom_urls():
                         await self.__handle_atom_url(atom_url)

         except (OperationalError, DatabaseError) as e:
                 await self.handle_db_error(e)
         except (TelegramDaemonException) as e:
                 e.set_atom_url(atom_url)
                 await self.client.report_err(e)
         except e_orig:
                 e = DaemonException()
                 e.set_atom_url(atom_url)
                 e.set_thread_url(None)
                 e.set_message(e_orig)
                 await self.client.report_err(e)


	def report_err(self, e: DaemonException):
         	pass