From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ammarfaizi2@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.8 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,NO_DNS_FOR_FROM
	autolearn=ham autolearn_force=no version=3.4.6
Received: from [10.7.7.5] (unknown [182.253.183.184])
	by gnuweeb.org (Postfix) with ESMTPSA id 0F9867E24F;
	Sat, 24 Dec 2022 21:39:05 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=default; t=1671917947;
	bh=hJOTnooq4cRBNXJMuDRn3weuYEjCGhdGbmj/5t3GXGo=;
	h=Date:Subject:From:To:Cc:References:In-Reply-To:From;
	b=JQLYSiHeF6q7+bHkBAU+TU78Arh7sT/2Ui4Q11RSH8uMserWcZ2H3bZw0W/YGEg58
	 nv2yYBGxDmZuaGRC2RkiDNUofi5x3x0cFshB2L92duJPCEDPDqDC2huqsIb4wnfjXp
	 WtSSAnRKTlNUUp5jN3oKxEgJqjNPqsjkxZQL07njTSi8u2dCLPlZWYDGmwgHVqa2sj
	 uvOetedIv6Pj5WjW3arUt2k3UH06WBLWhg4lHUyMCcLa88AdR43FYKCMcTnxlAl+Zw
	 b6w2gjPbkWO9pjPgXmejiBnCL1rljGm9ag4pH1C9/WlF2/Zd/zsAiNSeQIkiv3iYc7
	 CNK809roTzpSQ==
Message-ID: <3ae96fd7-a396-9404-babc-a0fd8a334e16@gnuweeb.org>
Date: Sun, 25 Dec 2022 04:39:02 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v4 12/17] telegram: Implement the log message for catching
 errors
Content-Language: en-US
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Muhammad Rizki <kiizuha@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
 GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
References: <20221221013347.1704-1-kiizuha@gnuweeb.org>
 <20221221013347.1704-13-kiizuha@gnuweeb.org>
 <c1b0c5cc-657e-1cad-0328-6fd6374515f3@gnuweeb.org>
In-Reply-To: <c1b0c5cc-657e-1cad-0328-6fd6374515f3@gnuweeb.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <gwml.vger.gnuweeb.org>

On 12/25/22 4:22 AM, Ammar Faizi wrote:
> This part is problematic, if you have MySQL error here, the previous
> 'try and except' statement won't catch it because it's already caught
> by your error logging.
> 
> Your error logging kills the recovery function that the caller function
> ('__run') provides.

I just fixed this myself in commit:

    3eb6a95d6028 ("telegram: listener: Fix missing MySQL error recovery function")

It only fixes the Telegram daemon, I'll wait for your patch to fix
the Discord daemon.

-- 
Ammar Faizi