From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, RCVD_IN_ZEN_BLOCKED_OPENDNS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=wiq3dtxF; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 785092109A93; Wed, 16 Jul 2025 12:41:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.166.53; helo=mail-io1-f53.google.com; envelope-from=axboe@kernel.dk; receiver= Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id C6EDB2109A93 for ; Wed, 16 Jul 2025 12:41:13 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-8731c3473c3so43041139f.1 for ; Wed, 16 Jul 2025 05:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1752669672; x=1753274472; darn=vger.gnuweeb.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5IyO6wUl//owvi+Xi5g+hOG+WKmfJL+fQ0DzM68WhPQ=; b=wiq3dtxFte1vechn9TxiN1r+MkVuYSjr6NAyaiygm3PDzNuUBH7ZQH6casrunZZWFc /KIBDLOGGxmQvIG5BLRbZ9v73NWtpOMUlrXGLkTwYfu3cJL0HKdz6osHKswEqGP4SBEK PbVFEEe1q0f04WkI2TQ0MMdpi8zcbeOCuRwZ5r6WqwL3hYBk2i4VpiURLl79CqEIWkmJ kKUL/+wBzd0+VGBYYEeb/JDW/YoJqQP3WAtn/wtQCbaJFDNihBAvJGcibQWMp1BjTNRB g3Tu/3ud8D2cX7x05wHoUf2Be3Skh0ioOyYZEjpDFc5pxWboMu378O5ArtQdegpa8FgH 2f1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752669672; x=1753274472; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5IyO6wUl//owvi+Xi5g+hOG+WKmfJL+fQ0DzM68WhPQ=; b=BwbAyvnpl7En+ts8DUQC8BS4szmxxH2e6Ysba/rIdW7eE4QW3n5xmbU9KyjCcjClgV 6Co8ghOMdFdyC+AotzyqlnqdhB2KLZKd2fzHdLPx8a9He1CzwvQV+pALtGt6Er4SCnRj pjjx2AFJsKC3F5xEVTExjrF5z997AtJWJNRs0hrk46DQiBHTaa2mNkBKKSODOaPahFEB hfxEFgEZispuj3aKK6bgPPxoTG+W2owmE+C45Ve9tPWMz5J5nU55xS2/rynkUrnxuqS7 wAYzmfXUPhe0sY47RDnK6Go/QKUrjCQUwBP9XGxDBoA5jPuftkNwW8ObJNtALiWzk3ip qyQQ== X-Forwarded-Encrypted: i=1; AJvYcCW3UxAWwyjxnK3g1AR4O/qyvZRF/xvU5K/geXNGbYBJkppkHb/TwGnuhCSuCbpOGcr84jou@vger.gnuweeb.org X-Gm-Message-State: AOJu0YxR6fWk7FT3MPgupYhYq6Q1LwWqKyCLRWtrCzM+nM4UpmvG07QH CmEctHHGvvzFSi+muB3yu6z72UCcksba/dInOvCq/zmzf9Nb3vcdAe6Y8+HV8t37SqA= X-Gm-Gg: ASbGncvC/C19vfDQroM3hTDQHMxlrpLPu7T2C1W+QEM38m+Ril7YzS2Xcq4M7MtmANR qiDNK+Ze34qDBAapqgMTNo6o2wlQdZm/qcnFz90vQf70kcaQBeOQY46bNHwVdw82AzoyQj+HvLM 8Yy+BmaJ21dEyGiVxHbh7ITfSJXih2spcbVab08/IDLZL8416s0Ix0Bz9mVyzcHiky38/7jMqGp 8GCJVv/gQ/ofKecikDBdMC2BLsxlasWY7N4UtnnIZ4f1QMyYur9pDw2HOJfAWv7kzU0rclhA1JL hFl9ZAEQFWHKQSFup8C/Pi1pkdPaBKatk3nEGEcTShKpKQETOKMYAcZtTdL/0ioJWLX5XwbCE4L IEafOWNSM+toUX+xZY90= X-Google-Smtp-Source: AGHT+IEaXkz1qDW6FctDCit+gCLbqFb/TZneYPdal+/fxuNQLUjjm3E8xB2iDIfQRJdJclhXIeMwNw== X-Received: by 2002:a05:6602:641e:b0:861:d71f:33e3 with SMTP id ca18e2360f4ac-879c2877178mr253394639f.5.1752669672141; Wed, 16 Jul 2025 05:41:12 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50556973045sm3044134173.83.2025.07.16.05.41.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 05:41:11 -0700 (PDT) Message-ID: <3b28fddb-2171-4f2f-9729-0c0ed14d20cc@kernel.dk> Date: Wed, 16 Jul 2025 06:41:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH liburing v2 0/3] Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build error To: Alviro Iskandar Setiawan Cc: Ammar Faizi , GNU/Weeb Mailing List , Linux Kernel Mailing List , io-uring Mailing List References: <20250716004402.3902648-1-alviro.iskandar@gnuweeb.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <20250716004402.3902648-1-alviro.iskandar@gnuweeb.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: On 7/15/25 6:43 PM, Alviro Iskandar Setiawan wrote: > Hello, > > This is the v2 revision of the patch series to address the Android > build error related to `memfd_create()`. The series consists of three > patches: Took a closer look at this. A few comments: For patch 1, maybe just bring back the configure test and not bother with a revert style commit? There is nothing in test/ that uses memfd_create, so there's no point bringing it back in there. IOW, patch 2 can be dropped, as it's really just dropping bits that patch 1 re-added for some reason. All that's needed is to add it to the examples/ helpers. If it's needed for test/ later, then it can get added at that time. All of that to say, I'd just add the configure bit and the examples/ helper in a single patch and not worry about test/ at all. -- Jens Axboe