Re: [PATCH v1 01/18] Add atom_broadcast.sql

[Muhammad Rizki <kiizuha@gnuweeb.org>]

On 27/07/2022 21.45, Ammar Faizi wrote:
> On 7/27/22 9:46 AM, Muhammad Rizki wrote:
>> Just add an atom_broadcast.sql file to create new table.
>>
>> Signed-off-by: Muhammad Rizki <kiizuha@gnuweeb.org>
>> ---
>>   .gitignore                |  4 ++++
>>   daemon/atom_broadcast.sql | 25 +++++++++++++++++++++++++
>>   2 files changed, 29 insertions(+)
>>   create mode 100644 daemon/atom_broadcast.sql
> 
> Please don't create another SQL file, just use the same database with
> different table. I really don't see the need to use 2 databases. Hmmm?
> 

Oh yes I forget to combine the SQL with the old one, I will amend 
thiscommit and merge atom_broadcast.sql with the old one.

>> +CREATE TABLE `atom_urls` (
>> +  `id` bigint unsigned NOT NULL AUTO_INCREMENT,
>> +  `url` varchar(64) CHARACTER SET utf8mb4 COLLATE 
>> utf8mb4_unicode_520_ci NOT NULL,
> 
> Just max this one out to varchar(255).
> 

Noted, thanks!

>> +  `created_at` datetime NOT NULL,
>> +  PRIMARY KEY (`id`),
>> +  UNIQUE KEY `url` (`url`),
>> +  KEY `created_at` (`created_at`)
>> +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_520_ci;
>> +
>> +DROP TABLE IF EXISTS `broadcast_chats`;
>> +CREATE TABLE `broadcast_chats` (
>> +  `id` bigint unsigned NOT NULL AUTO_INCREMENT,
>> +  `chat_id` bigint NOT NULL,
>> +  `username` varchar(32),
>> +  `name` varchar(64) CHARACTER SET utf8mb4 COLLATE 
>> utf8mb4_unicode_520_ci NOT NULL,
>> +  `type` varchar(32) NOT NULL,
> 
> What is the purpose of the `type` field here?
> 

It's a chat type to define is it a group chat or private chat, so what 
I'm thinking is, if someone want to receive via private chat I just
make the `type` column. If this is not necessary I can just amend
this commit and edit all related code.

>> +  `link` varchar(64),
>> +  `created_at` datetime NOT NULL,
>> +  PRIMARY KEY (`id`),
>> +  UNIQUE KEY `chat_id` (`chat_id`),
>> +  KEY `created_at` (`created_at`)
>> +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_520_ci;
>> +
>> +-- 2022-07-25 09:26:43
>